Bug 165661

Summary: [Cocoa] Validation message for required checkbox doesn’t conform the the Apple Style Guide
Product: WebKit Reporter: mitz
Component: FormsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, jberlin, mitz, webkit-bug-importer
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

mitz
Reported 2016-12-09 10:28:38 PST
The form validation message for a required checkbox says “Check this box”. The Apple Style Guide says not to use “check” as a verb “when you mean the action of clicking a checkbox to select an option”. It also says “You select or deselect a checkbox”. It goes on to give this as an example of correct usage: “Select the ‘Object causes wrap’ checkbox”. So at least on Apple platforms, I think the validation message should be “Select this checkbox” instead of “Check this box”.
Attachments
Patch (7.66 KB, patch)
2016-12-09 10:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-12-09 10:38:17 PST
Created attachment 296660 [details] Patch
mitz
Comment 2 2016-12-09 10:42:28 PST
Comment on attachment 296660 [details] Patch Thanks!
Chris Dumez
Comment 3 2016-12-09 11:43:14 PST
Comment on attachment 296660 [details] Patch Clearing flags on attachment: 296660 Committed r209620: <http://trac.webkit.org/changeset/209620>
Chris Dumez
Comment 4 2016-12-09 11:43:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.