Bug 165647

Summary: DisallowUserAgentShadowContent moves out of non-UA shadow roots
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: ajuma, buildbot, cdumez, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews115 for mac-elcapitan none

Ryosuke Niwa
Reported 2016-12-08 20:07:58 PST
When DisallowUserAgentShadowContent is set, we always move out of all shadow roots regardless of whether they’re UA shadow root or not.
Attachments
Patch (9.97 KB, patch)
2017-07-14 16:39 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-elcapitan (1.82 MB, application/zip)
2017-07-14 17:59 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2017-07-14 16:39:00 PDT
Created attachment 315500 [details] Patch
Build Bot
Comment 2 2017-07-14 17:59:22 PDT
Comment on attachment 315500 [details] Patch Attachment 315500 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4122481 New failing tests: security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html
Build Bot
Comment 3 2017-07-14 17:59:23 PDT
Created attachment 315512 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Ryosuke Niwa
Comment 4 2017-07-16 18:42:26 PDT
Thanks for the fix!
WebKit Commit Bot
Comment 5 2017-07-16 19:10:45 PDT
Comment on attachment 315500 [details] Patch Clearing flags on attachment: 315500 Committed r219551: <http://trac.webkit.org/changeset/219551>
WebKit Commit Bot
Comment 6 2017-07-16 19:10:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.