Summary: | [Modern Media Controls] Remaining time label first appears way to the left | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, webkit-bug-importer | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antoine Quint
2016-12-08 17:07:39 PST
Created attachment 296597 [details]
Patch
Comment on attachment 296597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296597&action=review > Source/WebCore/ChangeLog:15 > + We would sometimes see the remaining time label be laid out in an incorrect position > + when a video would start playing because the time label was being committed from a > + previous value before, in the same frame, we would call the layout() function > + of MacOSInlineMediaControls which would set the newly computed location for the > + remaining time label, but because we would reset the list of dirty properties after > + calling all layout functions, the new value set in MacOSInlineMediaControls.layout() > + woudl be disregarded and the wrong, commited value would persist until it was reset > + in a much later frame. This is an extremely confusing 97 word sentence. Can you be a bit more clear? Also typo: woudl + commited Created attachment 296607 [details]
Patch for landing
|