Bug 165637

Summary: [Modern Media Controls] Remaining time label first appears way to the left
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2016-12-08 17:07:39 PST
[Modern Media Controls] Remaining time label first appears way to the left
Attachments
Patch (5.69 KB, patch)
2016-12-08 17:13 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.70 KB, patch)
2016-12-08 18:15 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2016-12-08 17:13:03 PST
Created attachment 296597 [details] Patch
Dean Jackson
Comment 2 2016-12-08 18:01:37 PST
Comment on attachment 296597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296597&action=review > Source/WebCore/ChangeLog:15 > + We would sometimes see the remaining time label be laid out in an incorrect position > + when a video would start playing because the time label was being committed from a > + previous value before, in the same frame, we would call the layout() function > + of MacOSInlineMediaControls which would set the newly computed location for the > + remaining time label, but because we would reset the list of dirty properties after > + calling all layout functions, the new value set in MacOSInlineMediaControls.layout() > + woudl be disregarded and the wrong, commited value would persist until it was reset > + in a much later frame. This is an extremely confusing 97 word sentence. Can you be a bit more clear? Also typo: woudl + commited
Antoine Quint
Comment 3 2016-12-08 18:15:56 PST
Created attachment 296607 [details] Patch for landing
Antoine Quint
Comment 4 2016-12-09 07:35:38 PST
https://trac.webkit.org/changeset/209607
Note You need to log in before you can comment on or make changes to this bug.