Bug 165629

Summary: [WebCrypto] Remove NoInterfaceObject attribute from SubtleCrypto Interface
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, cdumez, commit-queue, esprehn+autocc, jiewen_tan, kondapallykalyan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159638    
Attachments:
Description Flags
Patch
cdumez: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews115 for mac-yosemite
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Patch for landing
buildbot: commit-queue-
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Patch for landing none

Description Jiewen Tan 2016-12-08 15:13:15 PST
Remove NoInterfaceObject attribute from SubtleCrypto Interface.
Comment 1 Jiewen Tan 2016-12-08 16:01:38 PST
<rdar://problem/29586203>
Comment 2 Jiewen Tan 2016-12-08 16:03:49 PST
Created attachment 296584 [details]
Patch
Comment 3 Chris Dumez 2016-12-08 16:04:52 PST
Comment on attachment 296584 [details]
Patch

r=me but there are likely other tests that will need rebaselining.
Comment 4 Jiewen Tan 2016-12-08 16:10:02 PST
(In reply to comment #3)
> Comment on attachment 296584 [details]
> Patch
> 
> r=me but there are likely other tests that will need rebaselining.

Thanks, Chris. Let's wait for the EWS results.
Comment 5 Build Bot 2016-12-08 17:00:33 PST
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2656953

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 6 Build Bot 2016-12-08 17:00:37 PST
Created attachment 296595 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-12-08 17:17:58 PST
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2657056

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 8 Build Bot 2016-12-08 17:18:01 PST
Created attachment 296598 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-12-08 17:45:22 PST
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2657546

New failing tests:
js/dom/global-constructors-attributes.html
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 10 Build Bot 2016-12-08 17:45:25 PST
Created attachment 296604 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 11 Jiewen Tan 2016-12-08 18:00:15 PST
Created attachment 296605 [details]
Patch for landing
Comment 12 Build Bot 2016-12-08 18:07:20 PST
Comment on attachment 296584 [details]
Patch

Attachment 296584 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2657679

New failing tests:
js/dom/global-constructors-attributes-dedicated-worker.html
Comment 13 Build Bot 2016-12-08 18:07:24 PST
Created attachment 296606 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2016-12-08 19:39:35 PST
Comment on attachment 296605 [details]
Patch for landing

Attachment 296605 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2659317

New failing tests:
js/dom/global-constructors-attributes.html
Comment 15 Build Bot 2016-12-08 19:39:38 PST
Created attachment 296622 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 16 Jiewen Tan 2016-12-08 20:35:45 PST
Created attachment 296631 [details]
Patch for landing
Comment 17 WebKit Commit Bot 2016-12-08 23:46:26 PST
Comment on attachment 296631 [details]
Patch for landing

Clearing flags on attachment: 296631

Committed r209598: <http://trac.webkit.org/changeset/209598>