Bug 165599

Summary: [Readable Streams API] Implement ReadableByteStreamController desiredSize
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebCore Misc.Assignee: Romain Bellessort <romain.wkt>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, commit-queue, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Romain Bellessort
Reported 2016-12-08 07:10:57 PST
Implement ReadableByteStreamController desiredSize
Attachments
Patch (5.66 KB, patch)
2016-12-08 07:44 PST, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-12-08 07:44:59 PST
Created attachment 296513 [details] Patch
Alex Christensen
Comment 2 2016-12-09 09:44:47 PST
Comment on attachment 296513 [details] Patch Can desiredSize be set to values other than 1? I think that should be tested, as well as actually getting bytes and showing that the desiredSize is actually used correctly.
Darin Adler
Comment 3 2016-12-09 21:30:41 PST
Comment on attachment 296513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296513&action=review > LayoutTests/streams/readable-byte-stream-controller-expected.txt:13 > +PASS By default initial value of desiredSize should be 1 This does not seem to be sufficient testing.
WebKit Commit Bot
Comment 4 2016-12-09 21:56:43 PST
Comment on attachment 296513 [details] Patch Clearing flags on attachment: 296513 Committed r209649: <http://trac.webkit.org/changeset/209649>
WebKit Commit Bot
Comment 5 2016-12-09 21:56:47 PST
All reviewed patches have been landed. Closing bug.
Romain Bellessort
Comment 6 2016-12-12 08:00:23 PST
(In reply to comment #2) > Comment on attachment 296513 [details] > Patch > > Can desiredSize be set to values other than 1? I think that should be > tested, as well as actually getting bytes and showing that the desiredSize > is actually used correctly. (In reply to comment #3) > Comment on attachment 296513 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296513&action=review > > > LayoutTests/streams/readable-byte-stream-controller-expected.txt:13 > > +PASS By default initial value of desiredSize should be 1 > > This does not seem to be sufficient testing. For the moment, as the API is not yet fully implemented, desiredSize value cannot change. But my intent is to add more tests addressing desiredSize as other functions are implemented.
Note You need to log in before you can comment on or make changes to this bug.