Bug 165564

Summary: Add more missing trivial wasm ops.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Keith Miller
Reported 2016-12-07 16:27:16 PST
Add more missing trivial wasm ops.
Attachments
Patch (6.59 KB, patch)
2016-12-07 16:50 PST, Keith Miller 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-12-07 16:50:58 PST
Created attachment 296440 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-07 16:52:59 PST
Attachment 296440 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:68: [<lambda>] Undefined variable 'isUnary' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:68: [<lambda>] Undefined variable 'isBinary' [pylint/E0602] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2016-12-07 17:00:24 PST
Comment on attachment 296440 [details] Patch r=me Needs a Nop test.
Keith Miller
Comment 4 2016-12-07 17:14:09 PST
Committed r209503: <http://trac.webkit.org/changeset/209503>
Note You need to log in before you can comment on or make changes to this bug.