Bug 165545

Summary:

WebCore::AccessibilityRenderObject add the other missing BSTR roles tag names.

Product:

WebKit

Reporter:

Karim <karim>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, karim, mario, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Karim

Reported 2016-12-07 13:42:08 PST

Add the other tag names that should be returned as the role. See "document structure" https://wiki.mozilla.org/Accessibility/AT-Windows-API

Attachments
Patch (2.00 KB, patch) 2016-12-07 13:56 PST, Karim	no flags	Details Formatted Diff Diff
Patch (2.08 KB, patch) 2016-12-08 16:01 PST, Karim	no flags	Details Formatted Diff Diff
Patch (6.99 KB, patch) 2016-12-10 20:44 PST, Karim	no flags	Details Formatted Diff Diff
Patch (8.42 KB, patch) 2016-12-10 23:31 PST, Karim	no flags	Details Formatted Diff Diff
Patch (8.42 KB, patch) 2016-12-11 00:11 PST, Karim	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Karim

Comment 1 2016-12-07 13:56:55 PST

Created attachment 296418 [details] Patch

Karim

Comment 2 2016-12-08 16:01:13 PST

Created attachment 296582 [details] Patch

Alex Christensen

Comment 3 2016-12-09 09:49:20 PST

Comment on attachment 296582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296582&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Why not? This certainly changes behavior. It should be possible to write a test that verifies that the behavior was changed.

chris fleizach

Comment 4 2016-12-09 09:50:55 PST

Comment on attachment 296582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296582&action=review > Source/WebCore/ChangeLog:3 > + Added the other missing BSTR roles tag names. this line should be the name of the bug >> Source/WebCore/ChangeLog:8 >> + No new tests needed. > > Why not? This certainly changes behavior. It should be possible to write a test that verifies that the behavior was changed. agreed

Karim

Comment 5 2016-12-09 09:56:34 PST

On IRC they told me there should be no tests. > Comment on attachment 296582 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296582&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests needed. > > Why not? This certainly changes behavior. It should be possible to write a > test that verifies that the behavior was changed.

Karim

Comment 6 2016-12-10 20:44:54 PST

Created attachment 296847 [details] Patch

chris fleizach

Comment 7 2016-12-10 21:23:52 PST

Comment on attachment 296847 [details] Patch You'll also need to add the test expectations file that is created when you run this test Thanks

Karim

Comment 8 2016-12-10 23:31:49 PST

Created attachment 296856 [details] Patch

Karim

Comment 9 2016-12-11 00:11:47 PST

Created attachment 296858 [details] Patch