Bug 165540

Summary: [WebCrypto] Replace webkitSubtle with subtle for all crypto/workers/subtle/ tests
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: Tools / TestsAssignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160880    
Attachments:
Description Flags
Patch
bfulgham: review+, bfulgham: commit-queue-
Patch for landing none

Jiewen Tan
Reported 2016-12-07 12:59:28 PST
Replace webkitSubtle with subtle for all crypto/workers/subtle* tests.
Attachments
Patch (10.25 KB, patch)
2016-12-07 13:07 PST, Jiewen Tan 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (10.25 KB, patch)
2016-12-08 12:22 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2016-12-07 13:07:39 PST
Created attachment 296408 [details] Patch
Brent Fulgham
Comment 2 2016-12-08 08:32:24 PST
Comment on attachment 296408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296408&action=review r=me, but please fix the 'verift" typo. > LayoutTests/crypto/workers/subtle/resources/hrsa-postMessage-worker.js:19 > + postMessage({ result:false, message:'publicKey.usages should be ["verift"]' }); "verift" -> "verify"
Jiewen Tan
Comment 3 2016-12-08 12:20:19 PST
Comment on attachment 296408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296408&action=review Thanks Brent for reviewing my patch. >> LayoutTests/crypto/workers/subtle/resources/hrsa-postMessage-worker.js:19 >> + postMessage({ result:false, message:'publicKey.usages should be ["verift"]' }); > > "verift" -> "verify" Fixed.
Jiewen Tan
Comment 4 2016-12-08 12:22:36 PST
Created attachment 296546 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-12-08 13:43:22 PST
Comment on attachment 296546 [details] Patch for landing Clearing flags on attachment: 296546 Committed r209564: <http://trac.webkit.org/changeset/209564>
Note You need to log in before you can comment on or make changes to this bug.