Bug 165524

Summary: [Win] Some versions of Cygwin Perl generate incorrect C++ code.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2016-12-07 04:16:09 PST
Perl strings with variables seems to be handled differently, depending on which version of Cygwin Perl you are running. For example, when Cygwin Perl v5.14.2 is processing the string "$domJITClassName::$domJITClassName()\n", it will emit a warning saying the variable '$domJITClassName::' is being used uninitialized. This will generate invalid C++ code.
Attachments
Patch (3.15 KB, patch)
2016-12-07 04:47 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2016-12-07 04:18:49 PST
<rdar://problem/29508043>
Per Arne Vollan
Comment 2 2016-12-07 04:47:07 PST
Created attachment 296388 [details] Patch
Daniel Bates
Comment 3 2016-12-07 14:57:29 PST
Comment on attachment 296388 [details] Patch r=me
Per Arne Vollan
Comment 4 2016-12-08 00:38:24 PST
(In reply to comment #3) > Comment on attachment 296388 [details] > Patch > > r=me Thanks for reviewing :)
WebKit Commit Bot
Comment 5 2016-12-08 01:04:57 PST
Comment on attachment 296388 [details] Patch Clearing flags on attachment: 296388 Committed r209532: <http://trac.webkit.org/changeset/209532>
WebKit Commit Bot
Comment 6 2016-12-08 01:05:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.