Bug 165496

Summary: REGRESSION(r203912): Web Inspector: Navigation sidebar widths are not saved
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
mattbaker: review+
Patch none

Devin Rousso
Reported 2016-12-06 15:54:35 PST
Moving the width-saving WI.Setting logic to the WI.TabBrowser caused the navigation sidebar to no longer remember its width.
Attachments
Patch (7.45 KB, patch)
2016-12-06 15:57 PST, Devin Rousso 		mattbaker: review+
DetailsFormatted DiffDiff
Patch (7.40 KB, patch)
2016-12-07 17:24 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2016-12-06 15:57:37 PST
Created attachment 296341 [details] Patch
Matt Baker
Comment 2 2016-12-07 16:25:32 PST
Comment on attachment 296341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296341&action=review Looks good! r=me with nits > Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:299 > + _sidebarWidthDidChange(event) { Open brace should be on its own line. > Source/WebInspectorUI/UserInterface/Views/TabContentView.js:51 > + this._navigationSidebarWidthSetting = new WebInspector.Setting(identifier + "-navigation-sidebar-width", 300); Since 300 is used in two places lets make it a const: const defaultSidebarWidth = 300;
Devin Rousso
Comment 3 2016-12-07 17:24:32 PST
Created attachment 296448 [details] Patch
WebKit Commit Bot
Comment 4 2016-12-07 20:27:47 PST
Comment on attachment 296448 [details] Patch Clearing flags on attachment: 296448 Committed r209519: <http://trac.webkit.org/changeset/209519>
WebKit Commit Bot
Comment 5 2016-12-07 20:27:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.