Bug 165487

Summary: Correct SDKROOT values in xcconfig files
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2016-12-06 13:36:42 PST
rdar://problem/29539209
Attachments
proposed patch (18.08 KB, patch)
2016-12-06 13:49 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-12-06 13:49:28 PST
Created attachment 296314 [details] proposed patch There were a couple projects in Tools that had different code from everything else. As far as I can tell, that wasn't intentional. One of them got overlooked when converting to SDK selectors, and another is a new one that copied the configs.
WebKit Commit Bot
Comment 2 2016-12-06 13:52:06 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
mitz
Comment 3 2016-12-06 13:53:30 PST
Please make sure that this doesn’t cause any problems when working with the projects in the Xcode IDE, i.e. that it’s still possible to select Simulator destinations and build for the Simulator.
Alexey Proskuryakov
Comment 4 2016-12-06 14:02:43 PST
I could select a simulator destination, and the build started successfully (built bmalloc and WTF). It wasn't doing an incremental build after my command line one, but that never works for me.
WebKit Commit Bot
Comment 5 2016-12-06 16:35:17 PST
Comment on attachment 296314 [details] proposed patch Clearing flags on attachment: 296314 Committed r209434: <http://trac.webkit.org/changeset/209434>
WebKit Commit Bot
Comment 6 2016-12-06 16:35:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.