| Summary: | Correct SDKROOT values in xcconfig files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | WebKit Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2016-12-06 13:36:42 PST
Created attachment 296314 [details]
proposed patch
There were a couple projects in Tools that had different code from everything else. As far as I can tell, that wasn't intentional. One of them got overlooked when converting to SDK selectors, and another is a new one that copied the configs.
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Please make sure that this doesn’t cause any problems when working with the projects in the Xcode IDE, i.e. that it’s still possible to select Simulator destinations and build for the Simulator. I could select a simulator destination, and the build started successfully (built bmalloc and WTF). It wasn't doing an incremental build after my command line one, but that never works for me. Comment on attachment 296314 [details] proposed patch Clearing flags on attachment: 296314 Committed r209434: <http://trac.webkit.org/changeset/209434> All reviewed patches have been landed. Closing bug. |