Bug 165484

Summary: Add a new MachMessage class and use it for sending outgoing messages
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ossy, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2016-12-06 12:38:08 PST
Add a new MachMessage class and use it for sending outgoing messages
Comment 1 Anders Carlsson 2016-12-06 12:41:17 PST
Created attachment 296308 [details]
Patch
Comment 2 Sam Weinig 2016-12-06 13:44:46 PST
Comment on attachment 296308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296308&action=review

> Source/WebKit2/Platform/IPC/mac/MachMessage.cpp:36
> +    return std::unique_ptr<MachMessage> { new (NotNull, memory) MachMessage { length } };
> +
> +}

Extra newline.

> Source/WebKit2/Platform/IPC/mac/MachMessage.h:36
> +public:
> +
> +    static std::unique_ptr<MachMessage> create(size_t length);

Extra newline.
Comment 3 Anders Carlsson 2016-12-06 14:00:18 PST
Committed r209418: <http://trac.webkit.org/changeset/209418>
Comment 4 Csaba Osztrogon√°c 2016-12-07 03:31:10 PST
(In reply to comment #3)
> Committed r209418: <http://trac.webkit.org/changeset/209418>

It broke the Apple Mac cmake build:
https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/10484
Comment 5 Alex Christensen 2016-12-07 12:26:00 PST
http://trac.webkit.org/changeset/209467