| Summary: | Add a new MachMessage class and use it for sending outgoing messages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, ossy, sam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2016-12-06 12:38:08 PST
Created attachment 296308 [details]
Patch
Comment on attachment 296308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296308&action=review > Source/WebKit2/Platform/IPC/mac/MachMessage.cpp:36 > + return std::unique_ptr<MachMessage> { new (NotNull, memory) MachMessage { length } }; > + > +} Extra newline. > Source/WebKit2/Platform/IPC/mac/MachMessage.h:36 > +public: > + > + static std::unique_ptr<MachMessage> create(size_t length); Extra newline. Committed r209418: <http://trac.webkit.org/changeset/209418> (In reply to comment #3) > Committed r209418: <http://trac.webkit.org/changeset/209418> It broke the Apple Mac cmake build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/10484 |