Bug 165454

Summary: Move RenderElement::rendererForRootBackground to RenderView.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2016-12-05 20:11:35 PST
And remove the limitation that this function can only be called on isDocumentElementRenderer() objects.
Attachments
Patch (12.22 KB, patch)
2016-12-05 20:27 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.25 KB, patch)
2016-12-05 21:07 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.34 KB, patch)
2016-12-06 15:27 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-12-05 20:27:15 PST
Created attachment 296255 [details] Patch
alan
Comment 2 2016-12-05 21:07:29 PST
Created attachment 296261 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-12-06 15:15:10 PST
Comment on attachment 296261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296261&action=review > Source/WebCore/rendering/RenderView.cpp:523 > + if (!is<HTMLHtmlElement>(documentRenderer.element())) > + return &documentRenderer; > + > + if (documentRenderer.hasBackground()) > + return &documentRenderer; Swap these around and maybe add a comment saying that this is an HTML-specific behavior.
alan
Comment 4 2016-12-06 15:27:46 PST
Created attachment 296334 [details] Patch
WebKit Commit Bot
Comment 5 2016-12-06 17:16:09 PST
Comment on attachment 296334 [details] Patch Clearing flags on attachment: 296334 Committed r209438: <http://trac.webkit.org/changeset/209438>
WebKit Commit Bot
Comment 6 2016-12-06 17:16:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.