Bug 165454

Summary: Move RenderElement::rendererForRootBackground to RenderView.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2016-12-05 20:11:35 PST 
And remove the limitation that this function can only be called on isDocumentElementRenderer() objects.
Comment 1 zalan 2016-12-05 20:27:15 PST 
Created attachment 296255 [details]
Patch
Comment 2 zalan 2016-12-05 21:07:29 PST 
Created attachment 296261 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-12-06 15:15:10 PST 
Comment on attachment 296261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296261&action=review

> Source/WebCore/rendering/RenderView.cpp:523
> +    if (!is<HTMLHtmlElement>(documentRenderer.element()))
> +        return &documentRenderer;
> +
> +    if (documentRenderer.hasBackground())
> +        return &documentRenderer;

Swap these around and maybe add a comment saying that this is an HTML-specific behavior.
Comment 4 zalan 2016-12-06 15:27:46 PST 
Created attachment 296334 [details]
Patch
Comment 5 WebKit Commit Bot 2016-12-06 17:16:09 PST 
Comment on attachment 296334 [details]
Patch

Clearing flags on attachment: 296334

Committed r209438: <http://trac.webkit.org/changeset/209438>
Comment 6 WebKit Commit Bot 2016-12-06 17:16:13 PST 
All reviewed patches have been landed.  Closing bug.