| Summary: | Enable visual viewports by default on Mac, and iOS Wk2 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | buildbot, jonlee, rniwa, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 164260 | ||
| Attachments: | |||
|
Description
Simon Fraser (smfr)
2016-12-05 19:24:30 PST
Created attachment 296248 [details]
Patch
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2631288 New failing tests: compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html compositing/layer-creation/fixed-position-out-of-view-scaled.html compositing/repaint/scroll-fixed-layer-no-content.html fast/zooming/client-rect-in-fixed-zoomed.html compositing/repaint/scroll-fixed-layer-out-of-view.html animations/trigger-container-scroll-boundaries.html compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html animations/trigger-container-scroll-simple.html animations/trigger-container-scroll-empty.html Created attachment 296252 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2631332 Number of test failures exceeded the failure limit. Created attachment 296253 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2631365 New failing tests: compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html compositing/layer-creation/fixed-position-out-of-view-scaled.html compositing/repaint/scroll-fixed-layer-no-content.html fast/zooming/client-rect-in-fixed-zoomed.html compositing/repaint/scroll-fixed-layer-out-of-view.html animations/trigger-container-scroll-boundaries.html compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html animations/trigger-container-scroll-simple.html animations/trigger-container-scroll-empty.html Created attachment 296257 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2631407 New failing tests: compositing/geometry/fixed-in-composited.html compositing/geometry/limit-layer-bounds-fixed.html compositing/geometry/limit-layer-bounds-fixed-positioned.html fast/scrolling/ios/remove-scrolling-role.html compositing/repaint/scroll-fixed-layer-no-content.html compositing/repaint/scroll-fixed-layer-out-of-view.html scrollingcoordinator/ios/non-stable-viewport-scroll.html fast/overflow/position-fixed-transform-clipping.html compositing/layer-creation/fixed-position-under-transform.html animations/trigger-container-scroll-simple.html scrollingcoordinator/ios/ui-scrolling-tree.html Created attachment 296260 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 296276 [details]
Patch
Comment on attachment 296276 [details] Patch Attachment 296276 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2632151 Number of test failures exceeded the failure limit. Created attachment 296278 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 296276 [details] Patch Attachment 296276 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2632254 New failing tests: compositing/geometry/limit-layer-bounds-fixed.html compositing/geometry/fixed-in-composited.html compositing/layer-creation/no-compositing-for-sticky.html compositing/layer-creation/fixed-position-under-transform.html compositing/geometry/limit-layer-bounds-fixed-positioned.html Created attachment 296281 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 296290 [details]
Patch
Comment on attachment 296290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296290&action=review > Source/WebCore/page/FrameView.cpp:1862 > + if (m_layoutPhase == InViewSizeAdjust) > + return; I don't think it makes sense to update the layout viewport while in layout at all. (not just when InViewSizeAdjust) (though I assume we normally don't call back on it during layout -assertion maybe?) Comment on attachment 296290 [details] Patch Attachment 296290 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2634379 New failing tests: tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html tiled-drawing/scrolling/fixed/four-bars-zoomed.html Created attachment 296296 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 296290 [details] Patch Attachment 296290 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2634473 New failing tests: compositing/geometry/limit-layer-bounds-fixed.html compositing/geometry/fixed-in-composited.html compositing/layer-creation/no-compositing-for-sticky.html compositing/layer-creation/fixed-position-under-transform.html compositing/geometry/limit-layer-bounds-fixed-positioned.html Created attachment 296297 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
|