Bug 165423

Summary: pointer lock should exit when a js alert is shown
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: New BugsAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
jer.noble: review+
Patch for landing.
jeremyj-wk: commit-queue-
Patch for landing. none

Jeremy Jones
Reported 2016-12-05 15:08:31 PST
pointer lock should exit when a js alert is shown
Attachments
Patch (3.18 KB, patch)
2016-12-05 15:09 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (4.17 KB, patch)
2016-12-05 21:24 PST, Jeremy Jones 		jer.noble: review+
DetailsFormatted DiffDiff
Patch for landing. (5.85 KB, patch)
2016-12-07 19:19 PST, Jeremy Jones 		jeremyj-wk: commit-queue-
DetailsFormatted DiffDiff
Patch for landing. (5.84 KB, patch)
2016-12-07 22:04 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2016-12-05 15:09:51 PST
Created attachment 296197 [details] Patch
Jeremy Jones
Comment 2 2016-12-05 15:10:40 PST
rdar://problem/29430803
Jon Lee
Comment 3 2016-12-05 15:15:40 PST
Comment on attachment 296197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296197&action=review > Source/WebCore/page/DOMWindow.cpp:1145 > + page->pointerLockController().requestPointerUnlock(); Should this exist in confirm() and prompt() dialogs as well?
Jeremy Jones
Comment 4 2016-12-05 21:24:58 PST
Created attachment 296265 [details] Patch
Jeremy Jones
Comment 5 2016-12-05 21:25:53 PST
(In reply to comment #3) > Comment on attachment 296197 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296197&action=review > > > Source/WebCore/page/DOMWindow.cpp:1145 > > + page->pointerLockController().requestPointerUnlock(); > > Should this exist in confirm() and prompt() dialogs as well? Added implementation for confirm() and prompt(). Also fixed build error.
Jer Noble
Comment 6 2016-12-06 16:43:44 PST
Comment on attachment 296265 [details] Patch r=me with nit: please generate expected.txt results before landing.
Jeremy Jones
Comment 7 2016-12-07 19:19:08 PST
Created attachment 296461 [details] Patch for landing.
Jeremy Jones
Comment 8 2016-12-07 22:04:55 PST
Created attachment 296485 [details] Patch for landing.
WebKit Commit Bot
Comment 9 2016-12-07 22:15:46 PST
Comment on attachment 296485 [details] Patch for landing. Rejecting attachment 296485 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 296485, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ubmit return self.open(self.click(*args, **kwds)) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://webkit-queues.webkit.org/results/2649403
WebKit Commit Bot
Comment 10 2016-12-08 12:01:29 PST
Comment on attachment 296485 [details] Patch for landing. Clearing flags on attachment: 296485 Committed r209555: <http://trac.webkit.org/changeset/209555>
Note You need to log in before you can comment on or make changes to this bug.