Bug 165416

Summary: One esc to exit fullscreen and pointer lock
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: New BugsAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, jonlee, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Jeremy Jones
Reported 2016-12-05 14:34:32 PST
one esc to exit fullscreen and pointer lock
Attachments
Patch (3.80 KB, patch)
2016-12-05 14:58 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (4.12 KB, patch)
2016-12-05 21:43 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2016-12-07 15:51 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (13.13 KB, patch)
2016-12-07 15:54 PST, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2016-12-05 14:36:07 PST
rdar://problem/29430711
Jeremy Jones
Comment 2 2016-12-05 14:58:44 PST
Created attachment 296196 [details] Patch
Jon Lee
Comment 3 2016-12-05 15:13:31 PST
Comment on attachment 296196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296196&action=review > Source/WebCore/ChangeLog:3 > + one esc to exit fullscreen and pointer lock One > Source/WebCore/page/EventHandler.cpp:-3068 > - return true; Please explain in the change log why this is removed.
Jeremy Jones
Comment 4 2016-12-05 21:43:09 PST
Created attachment 296269 [details] Patch
Jeremy Jones
Comment 5 2016-12-06 09:43:26 PST
(In reply to comment #3) > Comment on attachment 296196 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296196&action=review > > > Source/WebCore/ChangeLog:3 > > + one esc to exit fullscreen and pointer lock > > One dOne > > > Source/WebCore/page/EventHandler.cpp:-3068 > > - return true; > > Please explain in the change log why this is removed. Done.
Jer Noble
Comment 6 2016-12-06 16:43:13 PST
Comment on attachment 296269 [details] Patch r=me with nit, please generate expected.txt results before landing.
Jeremy Jones
Comment 7 2016-12-07 15:51:18 PST
Created attachment 296429 [details] Patch
Jeremy Jones
Comment 8 2016-12-07 15:52:01 PST
Comment on attachment 296429 [details] Patch This is missing most of the patch.
Jeremy Jones
Comment 9 2016-12-07 15:54:05 PST
Created attachment 296430 [details] Patch
WebKit Commit Bot
Comment 10 2016-12-07 17:19:31 PST
Comment on attachment 296430 [details] Patch Clearing flags on attachment: 296430 Committed r209504: <http://trac.webkit.org/changeset/209504>
WebKit Commit Bot
Comment 11 2016-12-07 17:19:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.