Bug 165413

Summary: Web Inspector: remove ASSERT from InspectorDebuggerAgent::derefAsyncCallData
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2016-12-05 14:20:45 PST
An async call can be cleared without having been recorded. For example: - Breakpoints becoming enabled between setTimeout/clearTimeout - Inspector opening between setTimeout/clearTimeout - clearTimeout(999) will always go through InspectorInstrumentation
Attachments
Patch (1.68 KB, patch)
2016-12-05 14:35 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2016-12-05 14:21:05 PST
<rdar://problem/29517587>
Matt Baker
Comment 2 2016-12-05 14:35:23 PST
Created attachment 296189 [details] Patch
Blaze Burg
Comment 3 2016-12-05 14:36:43 PST
Comment on attachment 296189 [details] Patch rs=me
Joseph Pecoraro
Comment 4 2016-12-05 15:00:05 PST
Comment on attachment 296189 [details] Patch We could have a test for this right? Did the clearTimeout(999) on about:blank reproduce this? Either way I'm fine with the test.
WebKit Commit Bot
Comment 5 2016-12-05 17:02:16 PST
Comment on attachment 296189 [details] Patch Clearing flags on attachment: 296189 Committed r209367: <http://trac.webkit.org/changeset/209367>
WebKit Commit Bot
Comment 6 2016-12-05 17:02:20 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 7 2016-12-06 11:21:12 PST
(In reply to comment #4) > Comment on attachment 296189 [details] > Patch > > We could have a test for this right? Did the clearTimeout(999) on > about:blank reproduce this? Either way I'm fine with the test. To answer my own question, yes the clearTimeout(999) did reproduce this.
Blaze Burg
Comment 8 2016-12-07 16:44:02 PST
Still needs a test. It should be pretty basic.
Note You need to log in before you can comment on or make changes to this bug.