Bug 165388

Summary: STP 19 fails to launch on 16B255
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebCore Misc.Assignee: Ricky Mondello <rmondello>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, beidson, commit-queue, rmondello, thorton
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Re-declare the symbols as weak none

Beth Dakin
Reported 2016-12-05 11:13:42 PST
STP 19 fails to launch on 16B255 Crash on launch: Dyld Error Message: Symbol not found: _NSTouchBarDidExitCustomization Referenced from: /Applications/Safari Technology Preview.app/Contents/MacOS/../Frameworks/WebKitLegacy.framework/Versions/A/WebKitLegacy Expected in: /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit in /Applications/Safari Technology Preview.app/Contents/MacOS/../Frameworks/WebKitLegacy.framework/Versions/A/WebKitLegacy rdar://problem/29514476
Attachments
Patch (1.36 KB, patch)
2016-12-05 11:17 PST, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
Re-declare the symbols as weak (2.51 KB, patch)
2016-12-05 19:04 PST, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2016-12-05 11:17:15 PST
Created attachment 296164 [details] Patch
Beth Dakin
Comment 2 2016-12-05 11:22:21 PST
https://trac.webkit.org/changeset/209330
Beth Dakin
Comment 3 2016-12-05 11:26:39 PST
Follow-up: https://trac.webkit.org/changeset/209332
Tim Horton
Comment 4 2016-12-05 18:58:38 PST
Reopening for new patch
Ricky Mondello
Comment 5 2016-12-05 19:04:24 PST
Created attachment 296245 [details] Re-declare the symbols as weak
WebKit Commit Bot
Comment 6 2016-12-05 19:30:33 PST
Comment on attachment 296245 [details] Re-declare the symbols as weak Clearing flags on attachment: 296245 Committed r209379: <http://trac.webkit.org/changeset/209379>
Brady Eidson
Comment 7 2016-12-05 21:36:04 PST
I'm on 10.12.1 (non TouchBar machine) with the standard dev tools, and I saw a build failure after this patch related to nullability. I fixed in https://trac.webkit.org/changeset/209385
Tim Horton
Comment 8 2016-12-10 00:34:51 PST
My understanding is that this is fixed.
Brady Eidson
Comment 9 2016-12-10 09:38:55 PST
(In reply to comment #8) > My understanding is that this is fixed. Correct - I'm using STP 19 on that OS build with no problems.
Note You need to log in before you can comment on or make changes to this bug.