Bug 165361

Summary: [CSS Parser] Remove line numbers from StyleRule.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dave Hyatt
Reported 2016-12-03 12:26:51 PST
[CSS Parser] Remove line numbers from StyleRule.
Attachments
Patch (16.95 KB, patch)
2016-12-03 12:34 PST, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-12-03 12:34:34 PST
Created attachment 296058 [details] Patch
Dave Hyatt
Comment 2 2016-12-03 13:23:20 PST
Fixed in r209304.
Darin Adler
Comment 3 2016-12-03 14:43:32 PST
Windows build is failing now: c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\bindings\js\serializedscriptvalue.cpp(2735): warning C4715: 'WebCore::exceptionForSerializationFailure': not all control paths return a value [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
Darin Adler
Comment 4 2016-12-03 14:44:03 PST
EFL build also failing: ../../Source/WebCore/bindings/js/SerializedScriptValue.cpp:2735:1: error: control reaches end of non-void function [-Werror=return-type]
Darin Adler
Comment 5 2016-12-03 14:56:15 PST
Both of those are from Sam's patch, not this one. Sorry!
Note You need to log in before you can comment on or make changes to this bug.