Bug 165360

Summary: Use ASCIICType more, and improve it a little bit
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=165490
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-yosemite
none
Archive of layout-test-results from ews115 for mac-yosemite
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch
sam: review+
Patch
none
Patch none

Darin Adler
Reported 2016-12-03 11:51:44 PST
Use ASCIICType more, and improve it a little bit
Attachments
Patch (59.07 KB, patch)
2016-12-03 12:30 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-yosemite (1.79 MB, application/zip)
2016-12-03 13:52 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews115 for mac-yosemite (1.70 MB, application/zip)
2016-12-03 14:00 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (8.14 MB, application/zip)
2016-12-03 14:19 PST, Build Bot 		no flags
Details
Patch (59.75 KB, patch)
2016-12-03 15:04 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (58.99 KB, patch)
2016-12-04 13:49 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (58.57 KB, patch)
2016-12-04 14:25 PST, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Patch (58.62 KB, patch)
2016-12-06 08:46 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (58.74 KB, patch)
2016-12-06 08:47 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-12-03 12:30:08 PST
Created attachment 296057 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-03 12:31:57 PST
Attachment 296057 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGParserUtilities.cpp:65: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2016-12-03 13:52:53 PST
Comment on attachment 296057 [details] Patch Attachment 296057 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2615276 New failing tests: js/dom/JSON-stringify.html
Build Bot
Comment 4 2016-12-03 13:52:56 PST
Created attachment 296064 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-12-03 14:00:04 PST
Comment on attachment 296057 [details] Patch Attachment 296057 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2615284 New failing tests: js/dom/JSON-stringify.html
Build Bot
Comment 6 2016-12-03 14:00:06 PST
Created attachment 296066 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-12-03 14:19:15 PST
Comment on attachment 296057 [details] Patch Attachment 296057 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2615311 New failing tests: js/dom/JSON-stringify.html
Build Bot
Comment 8 2016-12-03 14:19:18 PST
Created attachment 296069 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Darin Adler
Comment 9 2016-12-03 15:04:28 PST
Created attachment 296076 [details] Patch
Darin Adler
Comment 10 2016-12-04 13:49:15 PST
Created attachment 296105 [details] Patch
Darin Adler
Comment 11 2016-12-04 14:25:27 PST
Created attachment 296107 [details] Patch
Darin Adler
Comment 12 2016-12-05 07:39:53 PST
GTK build failure seems unrelated to the patch. But I am not certain.
Sam Weinig
Comment 13 2016-12-05 10:47:42 PST
Comment on attachment 296107 [details] Patch r=me. No idea what is going on with the Gtk bot. I would try re-uploading the patch to see if it fixes it.
Darin Adler
Comment 14 2016-12-06 08:46:14 PST
Created attachment 296289 [details] Patch
Darin Adler
Comment 15 2016-12-06 08:47:38 PST
Created attachment 296291 [details] Patch
Darin Adler
Comment 16 2016-12-06 09:18:48 PST
Committed r209399: <http://trac.webkit.org/changeset/209399>
Note You need to log in before you can comment on or make changes to this bug.