Bug 165358

Summary: Remove various stray uses of WebCore::Dictionary
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
sam: review+
Patch none

Darin Adler
Reported 2016-12-03 09:35:00 PST
Remove various stray uses of WebCore::Dictionary
Attachments
Patch (45.11 KB, patch)
2016-12-03 09:42 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (48.38 KB, patch)
2016-12-03 17:29 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (47.50 KB, patch)
2016-12-04 13:44 PST, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Patch (49.82 KB, patch)
2016-12-06 09:15 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-12-03 09:42:13 PST
Created attachment 296049 [details] Patch
Darin Adler
Comment 2 2016-12-03 17:29:51 PST
Created attachment 296078 [details] Patch
Darin Adler
Comment 3 2016-12-04 13:44:25 PST
Created attachment 296103 [details] Patch
Darin Adler
Comment 4 2016-12-05 07:38:17 PST
Does anyone understand what these mutate fence failures in Windows linking are? Did I forget to include an inlines header somewhere, or is this a pre-existing build failure not caused by the patch?
Sam Weinig
Comment 5 2016-12-05 10:44:57 PST
Comment on attachment 296103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296103&action=review I think you need to sprinkle some FooInlines.h in the files that fail to link. > Source/WebCore/Modules/indexeddb/IDBDatabase.h:-30 > -#include "Dictionary.h" I think this need #include <heap/HeapInlines.h>
Darin Adler
Comment 6 2016-12-06 09:13:03 PST
I think the inlines situation boils down to this: - JSDictionary.h includes <runtime/JSCInlines.h>, which includes almost all the JavaScriptCore inlines including HeapInlines.h. - It's unclear precisely what code IDBDatabase.cpp, for example, compiles that requires HeapInlines.h, but everything worked before because of the JSCInlines.h include from JSDictionary.h. - I can add includes to fix each compiler error, but since I am not sure in a principled way what file needs to include what header and why, for now, I will put all the includes in the cpp files that fail to compile.
Darin Adler
Comment 7 2016-12-06 09:15:05 PST
Created attachment 296293 [details] Patch
Darin Adler
Comment 8 2016-12-06 20:58:51 PST
Committed r209446: <http://trac.webkit.org/changeset/209446>
Note You need to log in before you can comment on or make changes to this bug.