Bug 165354

Summary: Improve the behavior of scroll-into-view when the target is inside position:fixed
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa, ryanhaddad, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
zalan: review+
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Patch none

Simon Fraser (smfr)
Reported 2016-12-02 21:45:28 PST
Improve the behavior of scroll-into-view when the target is inside position:fixed
Attachments
Patch (49.56 KB, patch)
2016-12-02 22:02 PST, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Patch (49.54 KB, patch)
2016-12-03 08:47 PST, Simon Fraser (smfr) 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-yosemite (1.04 MB, application/zip)
2016-12-03 09:52 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.02 MB, application/zip)
2016-12-03 09:55 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-yosemite (1.69 MB, application/zip)
2016-12-03 09:58 PST, Build Bot 		no flags
Details
Patch (49.90 KB, patch)
2016-12-05 22:16 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-12-02 22:02:54 PST
Created attachment 296041 [details] Patch
alan
Comment 2 2016-12-03 08:46:31 PST
Comment on attachment 296041 [details] Patch We ought to find a better way to figure out "inside fixed" state (by changing the existing RenderObject::localToAbsolute(....., bool* wasFixed) logic).
Simon Fraser (smfr)
Comment 3 2016-12-03 08:47:35 PST
Created attachment 296047 [details] Patch
Simon Fraser (smfr)
Comment 4 2016-12-03 08:48:33 PST
(In reply to comment #2) > Comment on attachment 296041 [details] > Patch > > We ought to find a better way to figure out "inside fixed" state (by > changing the existing RenderObject::localToAbsolute(....., bool* wasFixed) > logic). We could do another ancestor walk to get it. Or were you thinking of something else?
Build Bot
Comment 5 2016-12-03 09:52:42 PST
Comment on attachment 296047 [details] Patch Attachment 296047 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2613834 New failing tests: fast/transforms/selection-bounds-in-transformed-view.html
Build Bot
Comment 6 2016-12-03 09:52:45 PST
Created attachment 296050 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-12-03 09:55:44 PST
Comment on attachment 296047 [details] Patch Attachment 296047 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2613842 New failing tests: fast/transforms/selection-bounds-in-transformed-view.html
Build Bot
Comment 8 2016-12-03 09:55:46 PST
Created attachment 296051 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 9 2016-12-03 09:58:43 PST
Comment on attachment 296047 [details] Patch Attachment 296047 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2613840 New failing tests: fast/transforms/selection-bounds-in-transformed-view.html
Build Bot
Comment 10 2016-12-03 09:58:46 PST
Created attachment 296052 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Simon Fraser (smfr)
Comment 11 2016-12-03 14:01:06 PST
https://trac.webkit.org/changeset/209299
Ryan Haddad
Comment 12 2016-12-05 14:07:06 PST
It looks like this change is responsible for the editing/ and fast/ test failures seen here on Sierra WK1: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r209345%20(1977)/results.html
Ryan Haddad
Comment 13 2016-12-05 14:08:57 PST
Reverted r209299 for reason: This change appears to have caused LayoutTest failures on Sierra WK1. Committed r209348: <http://trac.webkit.org/changeset/209348>
Ryan Haddad
Comment 14 2016-12-05 14:55:26 PST
(In reply to comment #13) > Reverted r209299 for reason: > > This change appears to have caused LayoutTest failures on Sierra WK1. > > Committed r209348: <http://trac.webkit.org/changeset/209348> It looks like the rollout took care of the failures: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/1981
Simon Fraser (smfr)
Comment 15 2016-12-05 21:48:20 PST
I can't reproduce those failures locally.
Simon Fraser (smfr)
Comment 16 2016-12-05 22:16:23 PST
Created attachment 296271 [details] Patch
Simon Fraser (smfr)
Comment 17 2016-12-05 23:57:39 PST
Same patch is all green in EWS.
Simon Fraser (smfr)
Comment 18 2016-12-06 12:01:50 PST
https://trac.webkit.org/r209411
Note You need to log in before you can comment on or make changes to this bug.