[mac-sierra] LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky failure

• Component: New Bugs
• Status: REOPENED ---

[Ryan Haddad]

LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky failure

This occurs on Sierra Release and Debug WK1 / WK2

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r209234%20(1623)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fpip-support%2Fpip-support-click.html

--- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS media.webkitPresentationMode is "picture-in-picture"
+FAIL media.webkitPresentationMode should be picture-in-picture. Was inline.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Ryan Haddad]

Marked as flaky on Sierra in http://trac.webkit.org/projects/webkit/changeset/209244

[Antoine Quint]

Hasn't been a problem since turning modern media controls on by default.

[Ryan Haddad]

Still appears to be happening on Sierra Debug: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r214431%20(179)/results.html

[Ryan Haddad]

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/215776

[Matt Lewis]

This has since started on Sierra Release: 
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3722

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r220964%20(3722)/results.html

[Ryan Haddad]

This test continues to be a flaky failure. Here is a diff from the most recent failure:

--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-actual.txt
@@ -8,4 +8,8 @@
 PASS successfullyParsed is true
 
 TEST COMPLETE
+FAIL media.webkitPresentationMode should be picture-in-picture. Was inline.
+PASS successfullyParsed is true
 
+TEST COMPLETE
+

[Ryan Haddad]

Marked test as flaky again in https://trac.webkit.org/changeset/225305/webkit

[Jason Lawrence]

I have removed the expectation.
https://trac.webkit.org/changeset/257535/webkit