Bug 165311 - [mac-sierra] LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky failure
Summary: [mac-sierra] LayoutTest media/modern-media-controls/pip-support/pip-support-c...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords:
Depends on:
Blocks: 164784
  Show dependency treegraph
 
Reported: 2016-12-02 10:01 PST by Ryan Haddad
Modified: 2020-02-26 20:53 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-12-02 10:01:07 PST
LayoutTest media/modern-media-controls/pip-support/pip-support-click.html is a flaky failure

This occurs on Sierra Release and Debug WK1 / WK2

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r209234%20(1623)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fpip-support%2Fpip-support-click.html

--- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-actual.txt
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS media.webkitPresentationMode is "picture-in-picture"
+FAIL media.webkitPresentationMode should be picture-in-picture. Was inline.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Ryan Haddad 2016-12-02 10:22:30 PST
Marked as flaky on Sierra in http://trac.webkit.org/projects/webkit/changeset/209244
Comment 2 Antoine Quint 2017-02-07 05:01:19 PST
Hasn't been a problem since turning modern media controls on by default.
Comment 3 Ryan Haddad 2017-03-27 17:21:10 PDT
Still appears to be happening on Sierra Debug: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r214431%20(179)/results.html
Comment 4 Ryan Haddad 2017-04-25 17:43:52 PDT
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/215776
Comment 6 Ryan Haddad 2017-11-29 15:51:29 PST
This test continues to be a flaky failure. Here is a diff from the most recent failure:

--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/pip-support/pip-support-click-actual.txt
@@ -8,4 +8,8 @@
 PASS successfullyParsed is true
 
 TEST COMPLETE
+FAIL media.webkitPresentationMode should be picture-in-picture. Was inline.
+PASS successfullyParsed is true
 
+TEST COMPLETE
+
Comment 7 Ryan Haddad 2017-11-29 16:39:50 PST
Marked test as flaky again in https://trac.webkit.org/changeset/225305/webkit
Comment 8 Jason Lawrence 2020-02-26 16:54:17 PST
I have removed the expectation.
https://trac.webkit.org/changeset/257535/webkit