Bug 165292

Summary: REGRESSION: LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Ryan Haddad
Reported 2016-12-01 17:27:52 PST
LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r209219%20(9698)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fcsp-exceptions.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/debugger/csp-exceptions-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/debugger/csp-exceptions-actual.txt @@ -12,4 +12,5 @@ -- Running test case: TriggerCSPExceptionOutsideOfScript PASS: CSP Exception caused outside of script evaluation should not pause. +PASS: CSP Exception caused outside of script evaluation should not pause.
Attachments
[PATCH] Proposed Fix (6.67 KB, patch)
2017-01-11 16:04 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-12-01 17:28:09 PST
<rdar://problem/29471892>
Ryan Haddad
Comment 2 2016-12-01 17:29:38 PST
Seems to be occurring most frequently on mac-wk2 debug.
Ryan Haddad
Comment 3 2016-12-09 16:20:45 PST
Marked test as flaky on mac-wk2 in http://trac.webkit.org/projects/webkit/changeset/209634
Joseph Pecoraro
Comment 4 2017-01-11 16:01:31 PST
This looks like a test issue that is easily resolved.
Joseph Pecoraro
Comment 5 2017-01-11 16:04:12 PST
Created attachment 298624 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 6 2017-01-11 16:05:04 PST
I was easily able to reproduce this by running the test individually. And occasionally (1/100) with --iterations=100. After updating the test I consistently see successes.
Geoffrey Garen
Comment 7 2017-01-11 17:01:52 PST
Comment on attachment 298624 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 8 2017-01-11 17:25:48 PST
Comment on attachment 298624 [details] [PATCH] Proposed Fix Clearing flags on attachment: 298624 Committed r210611: <http://trac.webkit.org/changeset/210611>
WebKit Commit Bot
Comment 9 2017-01-11 17:25:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.