Bug 165284

Summary: [Modern Media Controls] Show and populate the tracks panel
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, graouts, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Patch for landing none

Antoine Quint
Reported 2016-12-01 15:35:00 PST
[Modern Media Controls] Show and populate the tracks panel
Attachments
Patch (20.11 KB, patch)
2016-12-01 15:38 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (946.33 KB, application/zip)
2016-12-01 16:38 PST, Build Bot 		no flags
Details
Patch for landing (21.10 KB, patch)
2016-12-01 16:53 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2016-12-01 15:38:31 PST
Created attachment 295906 [details] Patch
Dean Jackson
Comment 2 2016-12-01 16:20:19 PST
Comment on attachment 295906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295906&action=review > Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:66 > +video::cue(:future) { Baller. Didn't know that was possible. > LayoutTests/platform/ios-simulator/TestExpectations:2748 > +media/modern-media-controls/tracks-support [ Skip ] I suggest [ Fail ] since the code will actually run to completion, and that way we can be sure that the tracks button will never accidentally show up.
Antoine Quint
Comment 3 2016-12-01 16:31:14 PST
(In reply to comment #2) > Comment on attachment 295906 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295906&action=review > > > Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:66 > > +video::cue(:future) { > > Baller. Didn't know that was possible. I didn't write this :) > > LayoutTests/platform/ios-simulator/TestExpectations:2748 > > +media/modern-media-controls/tracks-support [ Skip ] > > I suggest [ Fail ] since the code will actually run to completion, and that > way we can be sure that the tracks button will never accidentally show up. It won't, since there will be no tracks button to click.
Build Bot
Comment 4 2016-12-01 16:38:26 PST
Comment on attachment 295906 [details] Patch Attachment 295906 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2603978 New failing tests: media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html
Build Bot
Comment 5 2016-12-01 16:38:28 PST
Created attachment 295914 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Antoine Quint
Comment 6 2016-12-01 16:53:25 PST
Created attachment 295915 [details] Patch for landing
Antoine Quint
Comment 7 2016-12-01 18:08:26 PST
https://trac.webkit.org/changeset/209227
Note You need to log in before you can comment on or make changes to this bug.