Summary: | Make _WKFullscreenDelegate available to users of the WebKit2 C-API. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | andersca, commit-queue | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Jer Noble
2016-12-01 09:20:26 PST
Created attachment 295854 [details]
Patch
Created attachment 295881 [details]
Patch
The GTK error is in WebCore::jsSubtleCryptoPrototypeFunctionUnwrapKey(), unrelated to this patch. Comment on attachment 295881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295881&action=review > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59 > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page); If possible, please use __weak id here. (In reply to comment #4) > Comment on attachment 295881 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295881&action=review > > > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59 > > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page); > > If possible, please use __weak id here. Doesn't seem to be possible, as __weak only make sense when compiling under ARC, and WKPagePrivateMac.mm doesn't. Adding __weak here just generates a warning. (In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 295881 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=295881&action=review > > > > > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59 > > > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page); > > > > If possible, please use __weak id here. > > Doesn't seem to be possible, as __weak only make sense when compiling under > ARC, and WKPagePrivateMac.mm doesn't. Adding __weak here just generates a > warning. We're already storing the delegate in a WeakObjCPtr, but there doesn't seem to a way to mark the return value of a C function as __weak (or a parameter as __weak) without generating a compiler error. I guess I could do something like: #if !defined WEAK #if __has_feature(objc_arc) #define WEAK _weak #else #define WEAK #endif and then mark up the methods as WK_EXPORT WEAK id <...>; Does that seem right? We don't seem to use __weak in any of the other C-style APIs. Created attachment 299039 [details]
Patch for landing
Created attachment 299044 [details]
Patch for landing
Created attachment 299558 [details]
Patch for landing
Comment on attachment 299558 [details] Patch for landing Clearing flags on attachment: 299558 Committed r211094: <http://trac.webkit.org/changeset/211094> |