Bug 165245

Summary: Web Automation: expose navigator.webdriver if the page is controlled by automation
Product: WebKit Reporter: Blaze Burg <bburg>
Component: DOMAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cdumez, commit-queue, joepeck, mitz, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 165269    
Attachments:
Description Flags
Proposed Fix joepeck: review+

Blaze Burg
Reported 2016-11-30 23:40:44 PST
Add open source implementation.
Attachments
Proposed Fix (20.76 KB, patch)
2016-12-01 11:01 PST, Blaze Burg 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-11-30 23:41:38 PST
<rdar://problem/29449874>
Blaze Burg
Comment 2 2016-12-01 11:01:04 PST
Created attachment 295868 [details] Proposed Fix Needs to be landed manually with internal changes.
WebKit Commit Bot
Comment 3 2016-12-01 11:02:39 PST
Attachment 295868 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:43: The parameter name "navigator" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 4 2016-12-01 13:16:59 PST
Comment on attachment 295868 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=295868&action=review I'm sure we could write a test for this! > Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:37 > + NavigatorWebDriver(Frame*); Nit: Could mark this as explicit. I'm not sure how strict we are with this keyword.
Blaze Burg
Comment 5 2016-12-01 13:33:02 PST
Comment on attachment 295868 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=295868&action=review >> Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:37 >> + NavigatorWebDriver(Frame*); > > Nit: Could mark this as explicit. I'm not sure how strict we are with this keyword. OK
Blaze Burg
Comment 6 2016-12-01 13:34:07 PST
(In reply to comment #4) > Comment on attachment 295868 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295868&action=review > > I'm sure we could write a test for this! We have an integration test for this in Safari's WebDriver test suite, IIRC. I'll file a followup bug.
Blaze Burg
Comment 7 2016-12-01 13:39:42 PST
Committed r209198: <http://trac.webkit.org/changeset/209198>
Note You need to log in before you can comment on or make changes to this bug.