| Summary: | [Modern Media Controls] Provide a UI object to show a list of tracks | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, graouts, rniwa | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Antoine Quint
2016-11-30 20:34:33 PST
Created attachment 295814 [details]
Patch
Comment on attachment 295814 [details] Patch Attachment 295814 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2599125 New failing tests: media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html Created attachment 295817 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295814 [details] Patch Attachment 295814 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2599128 New failing tests: media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html Created attachment 295818 [details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295814 [details] Patch Attachment 295814 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2599176 New failing tests: media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html media/modern-media-controls/tracks-panel/tracks-panel-hide-esc-key.html Created attachment 295819 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 295843 [details]
Patch
Created attachment 295844 [details]
Patch
Comment on attachment 295844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295844&action=review > Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.css:36 > + font-family: -apple-system; Why isn't this the font inherited from the shadow root? Surely it is -apple-system everywhere, except for the time labels, which can be explicit on those elements. (In reply to comment #10) > Comment on attachment 295844 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295844&action=review > > > Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.css:36 > > + font-family: -apple-system; > > Why isn't this the font inherited from the shadow root? Surely it is > -apple-system everywhere, except for the time labels, which can be explicit > on those elements. Right, will fix. |