Bug 165213

Summary: [CSS Parser] Turn on the new CSS parser
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, jonlee, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=76992
Bug Depends on:    
Bug Blocks: 46591    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch
none
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews115 for mac-yosemite
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch
none
Patch zalan: review+

Description Dave Hyatt 2016-11-30 12:43:24 PST
[CSS Parser] Turn on the new CSS parser
Comment 1 Dave Hyatt 2016-11-30 12:44:17 PST
Created attachment 295743 [details]
Patch
Comment 2 Build Bot 2016-11-30 13:19:14 PST
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2596802

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-11-30 13:19:16 PST
Created attachment 295748 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-11-30 13:27:12 PST
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2596808

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-11-30 13:27:15 PST
Created attachment 295750 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-11-30 13:36:38 PST
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2596809

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-11-30 13:36:41 PST
Created attachment 295754 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-11-30 13:38:45 PST
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2596815

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-11-30 13:38:48 PST
Created attachment 295755 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Dave Hyatt 2016-12-02 08:47:40 PST
Created attachment 295947 [details]
Patch
Comment 11 Build Bot 2016-12-02 09:49:51 PST
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2607854

New failing tests:
fast/media/mq-color-gamut.html
fast/selectors/pseudo-element-inside-any.html
fast/backgrounds/repeat/parsing-background-repeat.html
cssom/cssvalue-comparison.html
fast/css/remove-shorthand.html
fast/gradients/generated-gradients.html
fast/text/crash-complex-text-surrogate.html
fast/css/css-set-selector-text.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/dom/HTMLElement/dynamic-editability-change.html
fast/css/unknown-pseudo-element-matching.html
animations/animation-add-events-in-handler.html
fast/selectors/not-active-hover-quirks.html
inspector/console/css-source-locations.html
transitions/svg-transitions.html
fast/css/css-selector-text.html
fast/css/large-value-csstext.html
fast/selectors/active-quirks.html
fast/css/media-rule-no-whitespace.html
Comment 12 Build Bot 2016-12-02 09:49:54 PST
Created attachment 295954 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 Build Bot 2016-12-02 09:58:01 PST
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2607877

New failing tests:
fast/selectors/pseudo-element-inside-any.html
fast/css/css-set-selector-text.html
cssom/cssvalue-comparison.html
fast/css/remove-shorthand.html
fast/gradients/generated-gradients.html
fast/dom/HTMLElement/dynamic-editability-change.html
fast/text/crash-complex-text-surrogate.html
fast/backgrounds/repeat/parsing-background-repeat.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/media/mq-color-gamut.html
fast/css/unknown-pseudo-element-matching.html
animations/animation-add-events-in-handler.html
transitions/svg-transitions.html
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
fast/css/media-rule-no-whitespace.html
fast/selectors/active-quirks.html
fast/css/large-value-csstext.html
Comment 14 Build Bot 2016-12-02 09:58:04 PST
Created attachment 295956 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2016-12-02 10:02:32 PST
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2607852

New failing tests:
fast/media/mq-color-gamut.html
fast/css/css-set-selector-text.html
cssom/cssvalue-comparison.html
fast/css/remove-shorthand.html
fast/gradients/generated-gradients.html
fast/text/crash-complex-text-surrogate.html
fast/backgrounds/repeat/parsing-background-repeat.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/dom/HTMLElement/dynamic-editability-change.html
fast/css/unknown-pseudo-element-matching.html
animations/animation-add-events-in-handler.html
transitions/svg-transitions.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
fast/css/large-value-csstext.html
fast/css/media-rule-no-whitespace.html
Comment 16 Build Bot 2016-12-02 10:02:35 PST
Created attachment 295957 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 17 Build Bot 2016-12-02 10:07:52 PST
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2607887

New failing tests:
fast/media/mq-color-gamut.html
fast/text/letterpress-different.html
fast/css/css-set-selector-text.html
fast/text/trak-optimizeLegibility.html
fast/css/remove-shorthand.html
fast/selectors/pseudo-element-inside-any.html
fast/gradients/generated-gradients.html
fast/text/crash-complex-text-surrogate.html
fast/backgrounds/repeat/parsing-background-repeat.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/shadow-dom/slotted-pseudo-element-css-text.html
fast/dom/HTMLElement/dynamic-editability-change.html
animations/animation-add-events-in-handler.html
transitions/svg-transitions.html
fast/css/media-rule-no-whitespace.html
fast/css/large-value-csstext.html
Comment 18 Build Bot 2016-12-02 10:07:56 PST
Created attachment 295958 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 19 Dave Hyatt 2016-12-02 15:09:34 PST
Created attachment 296008 [details]
Patch
Comment 20 WebKit Commit Bot 2016-12-02 15:10:59 PST
Attachment 296008 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSParser.cpp:254:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 21 Build Bot 2016-12-02 16:10:41 PST
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2609898

New failing tests:
cssom/cssvalue-comparison.html
animations/animation-add-events-in-handler.html
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
fast/selectors/hover-quirks.html
Comment 22 Build Bot 2016-12-02 16:10:45 PST
Created attachment 296015 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 23 Build Bot 2016-12-02 16:14:03 PST
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2609893

New failing tests:
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
cssom/cssvalue-comparison.html
animations/animation-add-events-in-handler.html
Comment 24 Build Bot 2016-12-02 16:14:08 PST
Created attachment 296016 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 25 Build Bot 2016-12-02 16:20:28 PST
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2609912

New failing tests:
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
cssom/cssvalue-comparison.html
animations/animation-add-events-in-handler.html
Comment 26 Build Bot 2016-12-02 16:20:31 PST
Created attachment 296017 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 27 Build Bot 2016-12-02 16:30:30 PST
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2609914

New failing tests:
animations/animation-add-events-in-handler.html
fast/shadow-dom/slotted-pseudo-element-css-text.html
Comment 28 Build Bot 2016-12-02 16:30:35 PST
Created attachment 296019 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 29 Dave Hyatt 2016-12-03 13:45:16 PST
Created attachment 296063 [details]
Patch
Comment 30 Build Bot 2016-12-03 14:44:43 PST
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2615745

New failing tests:
fast/selectors/not-active-hover-quirks.html
fast/selectors/hover-quirks.html
Comment 31 Build Bot 2016-12-03 14:44:47 PST
Created attachment 296071 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 32 Build Bot 2016-12-03 14:49:09 PST
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2615747

New failing tests:
fast/selectors/not-active-hover-quirks.html
fast/selectors/hover-quirks.html
Comment 33 Build Bot 2016-12-03 14:49:13 PST
Created attachment 296073 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 34 Build Bot 2016-12-03 14:56:40 PST
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2615749

New failing tests:
fast/selectors/not-active-hover-quirks.html
inspector/heap/tracking.html
Comment 35 Build Bot 2016-12-03 14:56:43 PST
Created attachment 296074 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 36 Build Bot 2016-12-03 15:00:22 PST
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2615754

New failing tests:
fast/shadow-dom/slotted-pseudo-element-css-text.html
Comment 37 Build Bot 2016-12-03 15:00:26 PST
Created attachment 296075 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 38 Dave Hyatt 2016-12-06 00:16:07 PST
Created attachment 296280 [details]
Patch
Comment 39 WebKit Commit Bot 2016-12-06 00:18:54 PST
Attachment 296280 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSParser.cpp:254:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 40 Build Bot 2016-12-06 01:31:47 PST
Comment on attachment 296280 [details]
Patch

Attachment 296280 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2632562

New failing tests:
fast/shadow-dom/slotted-pseudo-element-css-text.html
Comment 41 Build Bot 2016-12-06 01:31:52 PST
Created attachment 296284 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 42 Dave Hyatt 2016-12-06 08:08:21 PST
Created attachment 296287 [details]
Patch
Comment 43 Dave Hyatt 2016-12-06 08:10:20 PST
Created attachment 296288 [details]
Patch
Comment 44 Dave Hyatt 2016-12-06 08:55:16 PST
Turned on in r209396!