Summary: | Proxy is not allowed in the global prototype chain. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ggaren, keith_miller, msaboff, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2016-11-30 11:01:01 PST
Created attachment 295734 [details]
proposed patch.
Comment on attachment 295734 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295734&action=review r=me > LayoutTests/js/dom/proxy-is-not-allowed-in-global-prototype-chain.html:12 > + if (e == "TypeError: Proxy is not allowed in the global prototype chain.") > + log("PASS: onerror saw " + e); > + else > + log("FAIL: onerror saw unexpected exception " + e); > +} In tests like this, I think it's best juts to log the error message, without judging whether it's a pass or a fail. Our test infrastructure will flag it for review if the result ever changes -- but we don't know in advance that any change to error message text is definitely bad. Comment on attachment 295734 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295734&action=review >> LayoutTests/js/dom/proxy-is-not-allowed-in-global-prototype-chain.html:12 >> +} > > In tests like this, I think it's best juts to log the error message, without judging whether it's a pass or a fail. Our test infrastructure will flag it for review if the result ever changes -- but we don't know in advance that any change to error message text is definitely bad. OK, I'll change it accordingly. Thanks for the review. Landed in r209149: <http://trac.webkit.org/r209149>. |