Bug 165191

Summary: [GLIB] IndexedDB: Switch to use new encoder for IDBKeyData
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, bugs-noreply, commit-queue, jsbell, ossy
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
svillar: review+, svillar: commit-queue-
Patch for landing
none
Patch for landing none

Carlos Garcia Campos
Reported 2016-11-30 02:53:04 PST
Instead of using KeyedEncoder.
Attachments
Patch (4.99 KB, patch)
2016-11-30 02:58 PST, Carlos Garcia Campos 		svillar: review+
svillar: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (5.00 KB, patch)
2016-11-30 08:42 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.02 KB, patch)
2016-11-30 09:00 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-11-30 02:58:53 PST
Created attachment 295710 [details] Patch
Sergio Villar Senin
Comment 2 2016-11-30 06:15:41 PST
Comment on attachment 295710 [details] Patch Awesome. Check mac failures before landing
Carlos Garcia Campos
Comment 3 2016-11-30 06:39:15 PST
(In reply to comment #2) > Comment on attachment 295710 [details] > Patch > > Awesome. Check mac failures before landing Thanks, yes, I changed LegacySerializedKeyVersion -> legacySerializedKeyVersion in the declaration but not when used. I'll fix it.
Carlos Garcia Campos
Comment 4 2016-11-30 08:42:26 PST
Created attachment 295718 [details] Patch for landing
Carlos Garcia Campos
Comment 5 2016-11-30 09:00:28 PST
Created attachment 295721 [details] Patch for landing
Brady Eidson
Comment 6 2016-11-30 09:13:47 PST
Thanks! 👍👍👍
WebKit Commit Bot
Comment 7 2016-11-30 10:03:43 PST
Comment on attachment 295721 [details] Patch for landing Clearing flags on attachment: 295721 Committed r209135: <http://trac.webkit.org/changeset/209135>
WebKit Commit Bot
Comment 8 2016-11-30 10:03:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.