Bug 165191 - [GLIB] IndexedDB: Switch to use new encoder for IDBKeyData
Summary: [GLIB] IndexedDB: Switch to use new encoder for IDBKeyData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-11-30 02:53 PST by Carlos Garcia Campos
Modified: 2016-11-30 10:03 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2016-11-30 02:58 PST, Carlos Garcia Campos 		svillar: review+
svillar: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (5.00 KB, patch)
2016-11-30 08:42 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch for landing (5.02 KB, patch)
2016-11-30 09:00 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-11-30 02:53:04 PST 
Instead of using KeyedEncoder.
Comment 1 Carlos Garcia Campos 2016-11-30 02:58:53 PST 
Created attachment 295710 [details]
Patch
Comment 2 Sergio Villar Senin 2016-11-30 06:15:41 PST 
Comment on attachment 295710 [details]
Patch

Awesome. Check mac failures before landing
Comment 3 Carlos Garcia Campos 2016-11-30 06:39:15 PST 
(In reply to comment #2)
> Comment on attachment 295710 [details]
> Patch
> 
> Awesome. Check mac failures before landing

Thanks, yes, I changed LegacySerializedKeyVersion -> legacySerializedKeyVersion in the declaration but not when used. I'll fix it.
Comment 4 Carlos Garcia Campos 2016-11-30 08:42:26 PST 
Created attachment 295718 [details]
Patch for landing
Comment 5 Carlos Garcia Campos 2016-11-30 09:00:28 PST 
Created attachment 295721 [details]
Patch for landing
Comment 6 Brady Eidson 2016-11-30 09:13:47 PST 
Thanks! 👍👍👍
Comment 7 WebKit Commit Bot 2016-11-30 10:03:43 PST 
Comment on attachment 295721 [details]
Patch for landing

Clearing flags on attachment: 295721

Committed r209135: <http://trac.webkit.org/changeset/209135>
Comment 8 WebKit Commit Bot 2016-11-30 10:03:47 PST 
All reviewed patches have been landed.  Closing bug.