Bug 165187

Summary: Correct plugin sandbox after r208611
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, bfulgham, bshafiei, commit-queue, ddkilzer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2016-11-29 19:51:11 PST 
I misread the Scheme conditional clause I changed in <http://trac.webkit.org/changeset/208611> as if it was C++.

I should have recognized that Scheme's conditional looks like this:

(if (predicate ...)
    (stuff to do if true)
    (stuff to do if false))

Therefore, much of what I stripped out is still needed.
Comment 1 Brent Fulgham 2016-11-29 19:58:22 PST 
<rdar://problem/29431165>
Comment 2 Brent Fulgham 2016-11-29 20:01:12 PST 
Created attachment 295696 [details]
Patch
Comment 3 WebKit Commit Bot 2016-11-30 09:53:32 PST 
Comment on attachment 295696 [details]
Patch

Clearing flags on attachment: 295696

Committed r209133: <http://trac.webkit.org/changeset/209133>
Comment 4 WebKit Commit Bot 2016-11-30 09:53:36 PST 
All reviewed patches have been landed.  Closing bug.