Bug 165187

Summary: Correct plugin sandbox after r208611
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, bfulgham, bshafiei, commit-queue, ddkilzer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2016-11-29 19:51:11 PST
I misread the Scheme conditional clause I changed in <http://trac.webkit.org/changeset/208611> as if it was C++. I should have recognized that Scheme's conditional looks like this: (if (predicate ...) (stuff to do if true) (stuff to do if false)) Therefore, much of what I stripped out is still needed.
Attachments
Patch (2.08 KB, patch)
2016-11-29 20:01 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-11-29 19:58:22 PST
<rdar://problem/29431165>
Brent Fulgham
Comment 2 2016-11-29 20:01:12 PST
Created attachment 295696 [details] Patch
WebKit Commit Bot
Comment 3 2016-11-30 09:53:32 PST
Comment on attachment 295696 [details] Patch Clearing flags on attachment: 295696 Committed r209133: <http://trac.webkit.org/changeset/209133>
WebKit Commit Bot
Comment 4 2016-11-30 09:53:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.