Summary: | [Modern Media Controls] Controls are not visible when returning from picture-in-picture playback | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, graouts, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antoine Quint
2016-11-29 17:55:02 PST
Created attachment 295687 [details]
Patch
Comment on attachment 295687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295687&action=review > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:122 > + const host = this.host; > + const media = this.media; No need for these variables. Comment on attachment 295687 [details]
Patch
Where is the test?
Sam will be very angry that there isn't a test. (In reply to comment #2) > Comment on attachment 295687 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295687&action=review > > > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:122 > > + const host = this.host; > > + const media = this.media; > > No need for these variables. Nice, didn't know fat-arrow functions correctly scoped `this`. (In reply to comment #4) > Sam will be very angry that there isn't a test. I'm open to suggestions as to how to test this. A pixel test? Created attachment 295766 [details]
Patch for landing
Comment on attachment 295766 [details] Patch for landing Clearing flags on attachment: 295766 Committed r209156: <http://trac.webkit.org/changeset/209156> All reviewed patches have been landed. Closing bug. |