Bug 165180

Summary: [Modern Media Controls] Show an invalid placard when we fail to load a media file
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Antoine Quint 2016-11-29 17:47:18 PST
[Modern Media Controls] Show an invalid placard when we fail to load a media file
Comment 1 Antoine Quint 2016-11-29 17:49:27 PST
Created attachment 295684 [details]
Patch
Comment 2 Dean Jackson 2016-11-29 17:59:42 PST
Comment on attachment 295684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295684&action=review

> Source/WebCore/ChangeLog:8
> +        We now show a placard with an "invalid" icon when we fail to load the media file.

Is this a placard? Why isn't it just a inactive start button with a different image?
Comment 3 Antoine Quint 2016-11-29 18:01:37 PST
(In reply to comment #2)
> Comment on attachment 295684 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295684&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        We now show a placard with an "invalid" icon when we fail to load the media file.
> 
> Is this a placard? Why isn't it just a inactive start button with a
> different image?

Because it gets a black background as well and it conditions the display of the controls bar. It's really designed as a placard so it is natural to implement it as such.
Comment 4 WebKit Commit Bot 2016-11-29 19:06:15 PST
Comment on attachment 295684 [details]
Patch

Clearing flags on attachment: 295684

Committed r209111: <http://trac.webkit.org/changeset/209111>
Comment 5 WebKit Commit Bot 2016-11-29 19:06:18 PST
All reviewed patches have been landed.  Closing bug.