Bug 165171

Summary:

Add support for globalThis

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, chi187, commit-queue, karl+webkit, leo, lforschler, ljharb, mark.lam, m.goleb+bugzilla, msaboff, rniwa, ross.kirsling, saam, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

166915

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Patch for landing	none
Patch	none
Patch	none
Patch for landing	none

Keith Miller

Reported 2016-11-29 16:12:38 PST

Add support for global

Attachments
Patch (3.17 KB, patch) 2016-11-29 16:18 PST, Keith Miller	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.34 MB, application/zip) 2016-11-29 17:12 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (12.23 MB, application/zip) 2016-11-29 17:29 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1.75 MB, application/zip) 2016-11-29 17:35 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.24 MB, application/zip) 2016-11-29 22:16 PST, Build Bot	no flags	Details
Patch for landing (13.73 KB, patch) 2016-12-20 18:34 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (2.95 KB, patch) 2018-12-20 12:19 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch (3.16 KB, patch) 2018-12-20 12:21 PST, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (4.85 KB, patch) 2018-12-20 13:01 PST, Keith Miller	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2016-11-29 16:18:15 PST

Created attachment 295668 [details] Patch

Build Bot

Comment 2 2016-11-29 17:12:11 PST

Comment on attachment 295668 [details] Patch Attachment 295668 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2591732 New failing tests: js/dom/getOwnPropertyDescriptor.html

Build Bot

Comment 3 2016-11-29 17:12:14 PST

Created attachment 295677 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-11-29 17:29:21 PST

Comment on attachment 295668 [details] Patch Attachment 295668 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2591771 New failing tests: js/dom/getOwnPropertyDescriptor.html

Build Bot

Comment 5 2016-11-29 17:29:24 PST

Created attachment 295680 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2016-11-29 17:35:06 PST

Comment on attachment 295668 [details] Patch Attachment 295668 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2591813 New failing tests: js/dom/getOwnPropertyDescriptor.html

Build Bot

Comment 7 2016-11-29 17:35:09 PST

Created attachment 295682 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-11-29 22:16:54 PST

Comment on attachment 295668 [details] Patch Attachment 295668 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2593202 New failing tests: js/dom/getOwnPropertyDescriptor.html

Build Bot

Comment 9 2016-11-29 22:16:57 PST

Created attachment 295703 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Jordan Harband

Comment 10 2016-12-20 17:32:00 PST

Any update here? :-D

Keith Miller

Comment 11 2016-12-20 18:24:32 PST

(In reply to comment #10) > Any update here? :-D Whoops, totally forgot about this patch. I'll fix the test and cq again.

Keith Miller

Comment 12 2016-12-20 18:34:10 PST

Created attachment 297576 [details] Patch for landing

WebKit Commit Bot

Comment 13 2016-12-20 20:05:32 PST

Comment on attachment 297576 [details] Patch for landing Clearing flags on attachment: 297576 Committed r210052: <http://trac.webkit.org/changeset/210052>

WebKit Commit Bot

Comment 14 2016-12-20 20:05:36 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2016-12-21 20:55:26 PST

<rdar://problem/29782794>

Sergey Rubanov

Comment 16 2017-01-03 09:24:57 PST

Any info on next WebKit Nightly release date? Last release was 2 weeks ago

Lucas Forschler

Comment 17 2017-01-03 13:41:24 PST

The WebKit nightly builder was having an issue. I have kicked off a new build, and will watch its progress.

Lucas Forschler

Comment 18 2017-01-03 16:54:54 PST

r210247.dmg">https://builds-nightly.webkit.org/files/trunk/mac/WebKit-SVN-r210247.dmg

WebKit Commit Bot

Comment 19 2017-01-10 17:34:07 PST

Re-opened since this is blocked by bug 166915

Sergey Rubanov

Comment 20 2017-01-11 10:18:37 PST

This was (mistakenly?) landed to Safari TP 21

Jordan Harband

Comment 21 2017-01-11 13:12:29 PST

Not mistakenly - it predates the web compat issues that popped up. It should be reverted, but any web compat issues learned about via TP 21 would be very helpful.

Ryosuke Niwa

Comment 22 2017-01-11 14:45:59 PST

We had to rollout this feature it broke Polymer tests.

karl

Comment 23 2017-01-11 17:39:17 PST

Firefox has implemented it too in Nightly. https://bugzilla.mozilla.org/show_bug.cgi?id=1317422 It broke a couple of things. Flickr: https://bugzilla.mozilla.org/show_bug.cgi?id=1325907 Deezer: https://bugzilla.mozilla.org/show_bug.cgi?id=1326032 Jira: https://bugzilla.mozilla.org/show_bug.cgi?id=1328218

Jordan Harband

Comment 24 2018-12-18 20:14:47 PST

The identifier is now named `globalThis`; Chrome is already shipping it. Can this get another shot? :-)

Keith Miller

Comment 25 2018-12-19 13:40:20 PST

(In reply to Jordan Harband from comment #24) > The identifier is now named `globalThis`; Chrome is already shipping it. Can > this get another shot? :-) Sure, I forgot about this. Will upload a patch shortly.

Keith Miller

Comment 26 2018-12-20 12:19:16 PST

Created attachment 357848 [details] Patch

Keith Miller

Comment 27 2018-12-20 12:21:56 PST

Created attachment 357849 [details] Patch

Saam Barati

Comment 28 2018-12-20 12:22:34 PST

Comment on attachment 357849 [details] Patch Can you add a layout test asserting this is === window?

Mark Lam

Comment 29 2018-12-20 12:25:23 PST

Comment on attachment 357849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357849&action=review > Source/JavaScriptCore/ChangeLog:8 > + This patch adds spport for the globalThis property on the global spport => support

Keith Miller

Comment 30 2018-12-20 12:43:22 PST

(In reply to Saam Barati from comment #28) > Comment on attachment 357849 [details] > Patch > > Can you add a layout test asserting this is === window? Sounds good!

Keith Miller

Comment 31 2018-12-20 13:01:08 PST

Created attachment 357852 [details] Patch for landing

WebKit Commit Bot

Comment 32 2018-12-20 13:39:20 PST

Comment on attachment 357852 [details] Patch for landing Clearing flags on attachment: 357852 Committed r239464: <https://trac.webkit.org/changeset/239464>

WebKit Commit Bot

Comment 33 2018-12-20 13:39:22 PST

All reviewed patches have been landed. Closing bug.

Saam Barati

Comment 34 2018-12-20 14:34:19 PST

Comment on attachment 357852 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=357852&action=review > LayoutTests/js/globalThis-is-window.html:13 > +// testRunner.waitUntilDone(); oops

Saam Barati

Comment 35 2018-12-20 14:35:14 PST

Comment on attachment 357852 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=357852&action=review > Source/JavaScriptCore/runtime/JSGlobalObject.cpp:305 > + globalThis JSGlobalObject::m_globalThis DontEnum|CellProperty We should add tests where we - delete this property - ensure its not enumerable if such tests aren't in test262 already

Truitt Savell

Comment 36 2019-01-09 11:20:25 PST

It appears that this revision https://trac.webkit.org/changeset/239464/webkit did cause the 32-bit JSC test failure. failure: https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/3331 I ran a clean build of 32-bit JSC on 239463 and it passed all testing: https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/3391 I then ran a clean build of 239464 and it failed: https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/3435

Jordan Harband

Comment 37 2019-01-09 11:35:02 PST

Any idea why adding a global identifier would cause a test failure? It might be notable that `jsc` has no identifier for the global object prior to this feature (although it's still accessible via `Function('return this')()`). Could that be causing issues?

Ross Kirsling

Comment 38 2019-02-03 19:28:04 PST

*** Bug 186785 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.