Bug 165158

Summary: Remove WebPage::SetPageSuppressed
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix thorton: review+

Description Gavin Barraclough 2016-11-29 14:28:45 PST 
This was scaffolding. We've now refactored to the point that the information driving throttling originates from the UI process (so UI and web processes can have a consistent view of what should throttle), but we don't need a separate message to handle this - necessary state to determine is provided in ActivityState.
Comment 1 Gavin Barraclough 2016-11-29 14:29:57 PST 
*** Bug 163873 has been marked as a duplicate of this bug. ***
Comment 2 Gavin Barraclough 2016-11-29 14:34:30 PST 
Created attachment 295643 [details]
Fix
Comment 3 Tim Horton 2016-11-29 14:42:21 PST 
Comment on attachment 295643 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=295643&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2552
> +    if (changed)

Can we just early return and avoid all of this work if nothing has changed?
Comment 4 Gavin Barraclough 2016-11-29 14:57:01 PST 
(In reply to comment #3)
> Comment on attachment 295643 [details]
> Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295643&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2552
> > +    if (changed)
> 
> Can we just early return and avoid all of this work if nothing has changed?

I think this may require a larger change; will consider as a separate patch.
Comment 5 Gavin Barraclough 2016-11-29 17:00:37 PST 
Committed revision 209102.