Bug 165158

Summary: Remove WebPage::SetPageSuppressed
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix thorton: review+

Gavin Barraclough
Reported 2016-11-29 14:28:45 PST
This was scaffolding. We've now refactored to the point that the information driving throttling originates from the UI process (so UI and web processes can have a consistent view of what should throttle), but we don't need a separate message to handle this - necessary state to determine is provided in ActivityState.
Attachments
Fix (8.09 KB, patch)
2016-11-29 14:34 PST, Gavin Barraclough 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2016-11-29 14:29:57 PST
*** Bug 163873 has been marked as a duplicate of this bug. ***
Gavin Barraclough
Comment 2 2016-11-29 14:34:30 PST
Created attachment 295643 [details] Fix
Tim Horton
Comment 3 2016-11-29 14:42:21 PST
Comment on attachment 295643 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=295643&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2552 > + if (changed) Can we just early return and avoid all of this work if nothing has changed?
Gavin Barraclough
Comment 4 2016-11-29 14:57:01 PST
(In reply to comment #3) > Comment on attachment 295643 [details] > Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295643&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2552 > > + if (changed) > > Can we just early return and avoid all of this work if nothing has changed? I think this may require a larger change; will consider as a separate patch.
Gavin Barraclough
Comment 5 2016-11-29 17:00:37 PST
Committed revision 209102.
Note You need to log in before you can comment on or make changes to this bug.