Bug 165133

Summary: intersection-observer-entry-interface.html test fails on the bots
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, ryanhaddad, sam, simon.fraser
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
URL: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r209057%20(9622)/intersection-observer/intersection-observer-entry-interface-pretty-diff.html
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2016-11-28 22:46:55 PST 
intersection-observer-entry-interface.html is failing on the bots, but does not when the test is run locally on its own.
Comment 1 Simon Fraser (smfr) 2016-11-28 22:48:47 PST 
The bug is that TestController::ensureViewSupportsOptionsForTest() early returns if it thinks the current view supports the new test options. However, the code fails to check for a difference in the enableIntersectionObserver option.

In general, this code is confused about options that must be set before view creation, and those that can be set as normal preferences.
Comment 2 Simon Fraser (smfr) 2016-11-28 23:10:56 PST 
Created attachment 295585 [details]
Patch
Comment 3 WebKit Commit Bot 2016-11-29 09:16:27 PST 
Comment on attachment 295585 [details]
Patch

Clearing flags on attachment: 295585

Committed r209073: <http://trac.webkit.org/changeset/209073>
Comment 4 WebKit Commit Bot 2016-11-29 09:16:31 PST 
All reviewed patches have been landed.  Closing bug.