Bug 165129

Summary: Add simple way to implement Wasm ops that require more than one B3 opcode
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2016-11-28 17:53:08 PST
Add simple way to implement Wasm ops that require more than one B3 opcode
Attachments
Patch (30.18 KB, patch)
2016-11-28 18:05 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (27.83 KB, patch)
2016-11-29 04:14 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (34.21 KB, patch)
2016-11-29 11:20 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (34.21 KB, patch)
2016-11-29 11:23 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-11-28 18:05:48 PST
Created attachment 295562 [details] Patch
WebKit Commit Bot
Comment 2 2016-11-28 18:07:11 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Keith Miller
Comment 3 2016-11-29 04:14:47 PST
Created attachment 295590 [details] Patch
Geoffrey Garen
Comment 4 2016-11-29 10:28:59 PST
Comment on attachment 295590 [details] Patch r=me
Filip Pizlo
Comment 5 2016-11-29 10:29:56 PST
Comment on attachment 295590 [details] Patch Crazy!
Filip Pizlo
Comment 6 2016-11-29 10:30:08 PST
(In reply to comment #5) > Comment on attachment 295590 [details] > Patch > > Crazy! r=me too
Keith Miller
Comment 7 2016-11-29 10:35:05 PST
After talking to Filip offline, I think I'm going to change the arguments from $1 to @1 since that matches the B3 format.
Keith Miller
Comment 8 2016-11-29 10:35:52 PST
It should be a trivial change so I don't think it will need another review.
Keith Miller
Comment 9 2016-11-29 11:20:01 PST
Created attachment 295609 [details] Patch for landing
Keith Miller
Comment 10 2016-11-29 11:23:17 PST
Created attachment 295611 [details] Patch for landing
WebKit Commit Bot
Comment 11 2016-11-29 11:37:20 PST
Comment on attachment 295611 [details] Patch for landing Clearing flags on attachment: 295611 Committed r209083: <http://trac.webkit.org/changeset/209083>
WebKit Commit Bot
Comment 12 2016-11-29 11:37:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.