| Summary: | Add simple way to implement Wasm ops that require more than one B3 opcode | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, mark.lam, msaboff, saam | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Keith Miller
2016-11-28 17:53:08 PST
Created attachment 295562 [details]
Patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json". Created attachment 295590 [details]
Patch
Comment on attachment 295590 [details]
Patch
r=me
Comment on attachment 295590 [details]
Patch
Crazy!
(In reply to comment #5) > Comment on attachment 295590 [details] > Patch > > Crazy! r=me too After talking to Filip offline, I think I'm going to change the arguments from $1 to @1 since that matches the B3 format. It should be a trivial change so I don't think it will need another review. Created attachment 295609 [details]
Patch for landing
Created attachment 295611 [details]
Patch for landing
Comment on attachment 295611 [details] Patch for landing Clearing flags on attachment: 295611 Committed r209083: <http://trac.webkit.org/changeset/209083> All reviewed patches have been landed. Closing bug. |