Bug 165123

Summary: [Mac][WK2] Enable HTML interactive form validation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, beidson, cdumez, commit-queue, darin, jonlee, m.kurz+webkitbugs, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164382    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-11-28 16:16:36 PST
Enable HTML interactive form validation now that we have a native UI for it.
Attachments
Patch (3.03 KB, patch)
2016-11-28 16:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-11-28 16:16:50 PST
<rdar://problem/28944652>
Chris Dumez
Comment 2 2016-11-28 16:18:31 PST
Created attachment 295549 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-11-28 16:42:13 PST
Comment on attachment 295549 [details] Patch Making InteractiveFormValidationEnabled a non-experimental feature means that it won't get enabled by default in WTR, so maybe iOS-WK2 tests will be affected?
Chris Dumez
Comment 4 2016-11-28 16:43:31 PST
(In reply to comment #3) > Comment on attachment 295549 [details] > Patch > > Making InteractiveFormValidationEnabled a non-experimental feature means > that it won't get enabled by default in WTR, so maybe iOS-WK2 tests will be > affected? Ok, I'll wait to see if iOS EWS is happy then.
WebKit Commit Bot
Comment 5 2016-11-28 21:37:30 PST
Comment on attachment 295549 [details] Patch Clearing flags on attachment: 295549 Committed r209060: <http://trac.webkit.org/changeset/209060>
WebKit Commit Bot
Comment 6 2016-11-28 21:37:35 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 7 2016-11-29 09:05:20 PST
<rdar://problem/29421342>
m.kurz+webkitbugs
Comment 8 2016-12-08 13:49:05 PST
Shouldn't bug 28649 also get marked as resolved now? Isn't it a duplicate? What's unclear for me is if this gets rolled out both for Safari on macOS and iOS or just one of these plattforms?
Chris Dumez
Comment 9 2016-12-08 13:52:06 PST
(In reply to comment #8) > Shouldn't bug 28649 also get marked as resolved now? Isn't it a duplicate? > > What's unclear for me is if this gets rolled out both for Safari on macOS > and iOS or just one of these plattforms? I duped it to https://bugs.webkit.org/show_bug.cgi?id=164382. The reason https://bugs.webkit.org/show_bug.cgi?id=164382 is not closed yet because we have not yet enabled interactive validation on iOS WebKit1.
m.kurz+webkitbugs
Comment 10 2016-12-08 14:08:08 PST
Isn't iOS using WebKit2 since version 8 anyway? Who would be affected by fixing bug 164382?
Chris Dumez
Comment 11 2016-12-08 14:09:35 PST
(In reply to comment #10) > Isn't iOS using WebKit2 since version 8 anyway? Who would be affected by > fixing bug 164382? Apps using UIWebView instead of WKWebView.
m.kurz+webkitbugs
Comment 12 2016-12-08 14:13:12 PST
Got it, thanks!
Note You need to log in before you can comment on or make changes to this bug.