Bug 165101
| Summary: | Separate UIDelegate platform specific code into UIDelegateIOS and UIDelegateMac classes. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andrew Gold <agold> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, eric.carlson |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Andrew Gold
UIDelegate currently uses compiler flags to allow for platform specific login in UIDelegate. We should instead create subclasses UIDelegateMac and UIDelegateIOS to distinguish platform specific code.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Why is that an improvement? Subclassing is used for runtime polymorphism, so it's the wrong tool to use for platform specific code.
Andrew Gold
(In reply to comment #1)
> Why is that an improvement? Subclassing is used for runtime polymorphism, so
> it's the wrong tool to use for platform specific code.
Sorry, you're right, we don't want to subclass. What I meant was separate implementations so that we don't need the platform-specific compiler flags throughout UIDelegate.