|Summary:||Separate UIDelegate platform specific code into UIDelegateIOS and UIDelegateMac classes.|
|Product:||WebKit||Reporter:||Andrew Gold <agold>|
|Version:||WebKit Nightly Build|
Description Andrew Gold 2016-11-28 12:10:45 PST
UIDelegate currently uses compiler flags to allow for platform specific login in UIDelegate. We should instead create subclasses UIDelegateMac and UIDelegateIOS to distinguish platform specific code.
Comment 1 Alexey Proskuryakov 2016-11-28 15:59:46 PST
Why is that an improvement? Subclassing is used for runtime polymorphism, so it's the wrong tool to use for platform specific code.
Comment 2 Andrew Gold 2016-11-29 08:58:24 PST
(In reply to comment #1) > Why is that an improvement? Subclassing is used for runtime polymorphism, so > it's the wrong tool to use for platform specific code. Sorry, you're right, we don't want to subclass. What I meant was separate implementations so that we don't need the platform-specific compiler flags throughout UIDelegate.