Bug 165047

Summary: Fix exception scope verification failures in JSScope.cpp
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162351    
Attachments:
Description Flags
proposed patch. saam: review+

Description Mark Lam 2016-11-23 09:45:04 PST 
Patch coming.
Comment 1 Mark Lam 2016-11-23 09:49:52 PST 
Created attachment 295371 [details]
proposed patch.
Comment 2 Saam Barati 2016-11-28 14:13:51 PST 
Comment on attachment 295371 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295371&action=review

> Source/JavaScriptCore/runtime/JSScope.cpp:-244
> -            ASSERT_WITH_MESSAGE_UNUSED(throwScope, !throwScope.exception(), "When an exception occurs, the result of isUnscopable becomes false");

Why get rid of this?
Comment 3 Mark Lam 2016-11-28 15:12:29 PST 
Comment on attachment 295371 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295371&action=review

>> Source/JavaScriptCore/runtime/JSScope.cpp:-244
>> -            ASSERT_WITH_MESSAGE_UNUSED(throwScope, !throwScope.exception(), "When an exception occurs, the result of isUnscopable becomes false");
> 
> Why get rid of this?

Because it is now redundant.  The assertion before the "if (!unscopable)" check replaces it.
Comment 4 Mark Lam 2016-11-28 15:15:47 PST 
Thanks for the review.  Landed in r209028: <http://trac.webkit.org/r209028>.