Bug 165023

Summary: Make normal case fast in the input element limitString function
Product: WebKit Reporter: Darin Adler <darin>
Component: FormsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, mitz, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mitz: review+

Darin Adler
Reported 2016-11-21 21:56:49 PST
Make normal case fast in the input element limitString function
Attachments
Patch (46.59 KB, patch)
2016-11-21 22:13 PST, Darin Adler 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-11-21 22:13:21 PST
Created attachment 295326 [details] Patch
mitz
Comment 2 2016-11-21 22:36:09 PST
Comment on attachment 295326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295326&action=review > Source/WTF/ChangeLog:27 > + class and not repeat UAX16 in the names of the modes. Initial data members UAX14 > Source/WebCore/html/TextFieldInputType.cpp:389 > + auto firstBadCharacterIndex = string.find([] (UChar character) { Maybe if we knew why we’re doing this we’d use an adjective other than “bad” here.
Darin Adler
Comment 3 2016-11-22 09:16:15 PST
Committed r208963: <http://trac.webkit.org/changeset/208963>
Darin Adler
Comment 4 2016-11-22 10:26:29 PST
Comment on attachment 295326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295326&action=review >> Source/WebCore/html/TextFieldInputType.cpp:389 >> + auto firstBadCharacterIndex = string.find([] (UChar character) { > > Maybe if we knew why we’re doing this we’d use an adjective other than “bad” here. I renamed to firstNonTabControlCharacterIndex.
Note You need to log in before you can comment on or make changes to this bug.