Bug 165008

Summary:

[CMake] build fails after update to cmake 3.7

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

WebKitGTK

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bugs-noreply, clopez, commit-queue, dbates, fujii.hironori, gyuyoung.kim, joepeck, mcatanzaro, mitz, tpopela

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Philippe Normand

Reported 2016-11-21 07:30:24 PST

CMake Error at Source/cmake/WebKitMacros.cmake:297 (add_library): The install of the JavaScriptCore target requires changing an RPATH from the build tree, but this is not supported with the Ninja generator unless on an ELF-based platform. The CMAKE_BUILD_WITH_INSTALL_RPATH variable may be set to avoid this relinking step. Call Stack (most recent call first): Source/JavaScriptCore/CMakeLists.txt:1474 (WEBKIT_FRAMEWORK)

Attachments
Patch (1.70 KB, patch) 2016-11-21 11:58 PST, Carlos Alberto Lopez Perez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2016-11-21 07:40:49 PST

This is on an amd64 machine btw.

Carlos Alberto Lopez Perez

Comment 2 2016-11-21 08:23:27 PST

I guess it still work if you use Make instead of Ninja (by passing -G "Unix Makefiles" to CMake) This seems to be the CMake commit causing this: https://gitlab.kitware.com/cmake/cmake/commit/72dfca30b94ba1e85533c61a7b5a330dfbc04da5

Carlos Alberto Lopez Perez

Comment 3 2016-11-21 09:31:09 PST

Asked CMake developers about this at https://gitlab.kitware.com/cmake/cmake/issues/13934

Carlos Alberto Lopez Perez

Comment 4 2016-11-21 11:58:54 PST

Created attachment 295309 [details] Patch

Philippe Normand

Comment 5 2016-11-21 12:23:46 PST

Thanks Carlos!

WebKit Commit Bot

Comment 6 2016-11-21 12:32:52 PST

Comment on attachment 295309 [details] Patch Clearing flags on attachment: 295309 Committed r208951: <http://trac.webkit.org/changeset/208951>