Bug 164997

Summary:

set PYTHONPATH in separate COMMAND doesn't work with all CMake generators

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

Tools / Tests

Assignee:

Konstantin Tokarev <annulen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, Hironori.Fujii, lforschler, mcatanzaro

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Konstantin Tokarev 2016-11-20 01:37:31 PST

Fix for r201413.

Comment 1 Konstantin Tokarev 2016-11-20 01:39:23 PST

Created attachment 295278 [details]
Patch

Comment 2 Fujii Hironori 2016-11-20 20:29:04 PST

You can use '${CMAKE_EXECUTABLE} -E env' if all Windows port use CMake >=3.1. Right?
Bug 156833

Comment 3 Konstantin Tokarev 2016-11-20 23:50:56 PST

Makes sense!

Comment 4 Michael Catanzaro 2016-12-21 12:05:12 PST

So what does this fix...?

Comment 5 Konstantin Tokarev 2016-12-21 12:11:00 PST

This fixes build with "NMake Makefiles" CMake generator

Comment 6 Konstantin Tokarev 2016-12-21 12:19:44 PST

Comment on attachment 295278 [details]
Patch

Clearing flags on attachment: 295278

Committed r210071: <http://trac.webkit.org/changeset/210071>

Comment 7 Konstantin Tokarev 2016-12-21 12:19:52 PST

All reviewed patches have been landed.  Closing bug.