Bug 164997

Summary: set PYTHONPATH in separate COMMAND doesn't work with all CMake generators
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, fujii.hironori, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konstantin Tokarev
Reported 2016-11-20 01:37:31 PST
Fix for r201413.
Attachments
Patch (1.24 KB, patch)
2016-11-20 01:39 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-11-20 01:39:23 PST
Created attachment 295278 [details] Patch
Fujii Hironori
Comment 2 2016-11-20 20:29:04 PST
You can use '${CMAKE_EXECUTABLE} -E env' if all Windows port use CMake >=3.1. Right? Bug 156833
Konstantin Tokarev
Comment 3 2016-11-20 23:50:56 PST
Makes sense!
Michael Catanzaro
Comment 4 2016-12-21 12:05:12 PST
So what does this fix...?
Konstantin Tokarev
Comment 5 2016-12-21 12:11:00 PST
This fixes build with "NMake Makefiles" CMake generator
Konstantin Tokarev
Comment 6 2016-12-21 12:19:44 PST
Comment on attachment 295278 [details] Patch Clearing flags on attachment: 295278 Committed r210071: <http://trac.webkit.org/changeset/210071>
Konstantin Tokarev
Comment 7 2016-12-21 12:19:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.