| Summary: | Fix exception scope verification failures in JSC profiler files. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, ysuzuki | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 162351 | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2016-11-18 16:57:16 PST
Created attachment 295225 [details]
proposed patch.
Created attachment 295310 [details]
proposed patch: updated to use return { } where possible.
Comment on attachment 295310 [details] proposed patch: updated to use return { } where possible. View in context: https://bugs.webkit.org/attachment.cgi?id=295310&action=review > Source/JavaScriptCore/profiler/ProfilerCompilation.cpp:120 > + RETURN_IF_EXCEPTION(scope, { }); Why not make these assertions in this file since this is only used for debugging? Comment on attachment 295310 [details] proposed patch: updated to use return { } where possible. View in context: https://bugs.webkit.org/attachment.cgi?id=295310&action=review >> Source/JavaScriptCore/profiler/ProfilerCompilation.cpp:120 >> + RETURN_IF_EXCEPTION(scope, { }); > > Why not make these assertions in this file since this is only used for debugging? We were already checking for some exceptions in this code before. In this patch, I'm filling out more exception checks. It might be appropriate to replace all these with assertions, but that would be a change in behavior. I'll stick with the exception checks for now. We can consider a change of behavior to use assertions later if desired. Thanks for the review. Landed in r208968: <http://trac.webkit.org/r208968>. |