Bug 164941

Summary: WebKit nightly fails to build
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, bdakin, dbates, jer.noble, lforschler, mitz, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Beth Dakin
Reported 2016-11-18 11:55:11 PST
WebKit nightly fails to build In file included from /WebKit/208883/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:33: /WebKit/208883/Source/WebCore/platform/spi/cocoa/AVKitSPI.h:174:40: error: unknown type name 'NSTouchBar'; did you mean 'NSTouch'? @property (strong, readonly, nullable) NSTouchBar *touchBar; ^~~~~~~~~~ NSTouch rdar://problem/29332858
Attachments
Patch (1.22 KB, patch)
2016-11-18 11:57 PST, Beth Dakin 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2016-11-18 11:57:40 PST
Created attachment 295172 [details] Patch
Daniel Bates
Comment 2 2016-11-18 12:28:05 PST
Comment on attachment 295172 [details] Patch This looks sane to me. r=me
Beth Dakin
Comment 3 2016-11-18 14:03:32 PST
Actually we realized that this won't work. We are going to have to fix this with the SDK instead.
Note You need to log in before you can comment on or make changes to this bug.