Summary: | Salt network cache hashes | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | barraclough, beidson, bfulgham, cdumez, cgarcia, commit-queue, dbates, wilander | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2016-11-18 06:41:00 PST
Created attachment 295149 [details]
patch
Attachment 295149 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 295150 [details]
patch
Attachment 295150 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 295150 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=295150&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp:104 > SHA1 sha1; If we're really trying to make this more unidentifiable, should we be using SHA1? Comment on attachment 295150 [details]
patch
doesn't have to be cryptographically secure. r=me
Created attachment 295263 [details]
patch for landing
A bit more conservative version that still keeps the partition directories but names them with salted hashes. There might be performance benefits in keeping files in a single partition together.
Attachment 295263 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 295263 [details] patch for landing Clearing flags on attachment: 295263 Committed r208931: <http://trac.webkit.org/changeset/208931> All reviewed patches have been landed. Closing bug. Created attachment 295871 [details]
revert patch
Reverting due to PLT regression. Attachment 295871 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:155: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:178: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Reverted in https://trac.webkit.org/r209189 Created attachment 296511 [details]
patch for landing 2
Attachment 296511 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:182: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 296511 [details] patch for landing 2 Clearing flags on attachment: 296511 Committed r209554: <http://trac.webkit.org/changeset/209554> All reviewed patches have been landed. Closing bug. |