Bug 164911

Summary: [GTK] UI process crash in WebKit::WaylandCompositor::Surface::prepareTextureForPainting
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1392182
https://bugzilla.redhat.com/show_bug.cgi?id=1389894
https://bugzilla.redhat.com/show_bug.cgi?id=1406125
Attachments:
Description Flags
Patch mcatanzaro: review+

Description Michael Catanzaro 2016-11-18 04:10:48 PST 
UI process crash in WebKit::WaylandCompositor::Surface::prepareTextureForPainting. I have 39 reports of this:

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 WebKit::WaylandCompositor::Buffer::size at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp:140
 #1 WebKit::WaylandCompositor::Surface::prepareTextureForPainting at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp:217
 #2 WebKit::WaylandCompositor::getTexture at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp:490
 #3 WebKit::AcceleratedBackingStoreWayland::paint at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:93
 #4 webkitWebViewBaseDraw at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:539
 #5 gtk_widget_draw_internal at gtkwidget.c:7015
 #6 gtk_container_propagate_draw at gtkcontainer.c:3838
 #7 gtk_container_draw at gtkcontainer.c:3658
 #8 gtk_widget_draw_internal at gtkwidget.c:7015
 #9 gtk_container_propagate_draw at gtkcontainer.c:3838

|this| is null in WebKit::WaylandCompositor::Buffer::size. Full backtrace downstream.
Comment 1 Carlos Garcia Campos 2016-11-30 03:48:07 PST 
Created attachment 295713 [details]
Patch
Comment 2 Michael Catanzaro 2016-11-30 09:37:16 PST 
Comment on attachment 295713 [details]
Patch

Look, it's not spam. :)
Comment 3 Carlos Garcia Campos 2016-11-30 09:51:54 PST 
(In reply to comment #2)
> Comment on attachment 295713 [details]
> Patch
> 
> Look, it's not spam. :)

I'm not sure, I couldn't reproduce it . . . :-D
Comment 4 Carlos Garcia Campos 2016-11-30 23:52:22 PST 
Committed r209177: <http://trac.webkit.org/changeset/209177>
Comment 5 Michael Catanzaro 2016-12-01 05:48:44 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 295713 [details]
> > Patch
> > 
> > Look, it's not spam. :)
> 
> I'm not sure, I couldn't reproduce it . . . :-D

I just hit this crash two minutes ago. It's really not spam!